Skip to content

Comments

CI tweaks#109

Merged
ZippeyKeys12 merged 6 commits intorems-project:mainfrom
ZippeyKeys12:ci-stuff
Apr 27, 2025
Merged

CI tweaks#109
ZippeyKeys12 merged 6 commits intorems-project:mainfrom
ZippeyKeys12:ci-stuff

Conversation

@ZippeyKeys12
Copy link
Collaborator

@ZippeyKeys12 ZippeyKeys12 commented Apr 26, 2025

Strengthen CI and put style checks into separate jobs. As a result, we get more information (formatting/warnings won't stop tests from running). They are quick, so they shouldn't hurt the concurrent job limit too much...

Also incorporates #100, since I can't rebase that PR for merging.

@ZippeyKeys12 ZippeyKeys12 added the CI Related to CI infrastructure label Apr 26, 2025
@ZippeyKeys12 ZippeyKeys12 self-assigned this Apr 26, 2025
@ZippeyKeys12 ZippeyKeys12 force-pushed the ci-stuff branch 4 times, most recently from 5322170 to 2eb9c3b Compare April 27, 2025 01:15
@ZippeyKeys12 ZippeyKeys12 marked this pull request as ready for review April 27, 2025 01:25
samcowger and others added 6 commits April 26, 2025 21:31
This directory is created if CN is built in a local switch. Though this isn't
the prescribed build process, I don't think there's any other natural way for
this directory to appear, and I don't see any harm in ignoring it.
@ZippeyKeys12 ZippeyKeys12 merged commit d6bf6eb into rems-project:main Apr 27, 2025
8 checks passed
@ZippeyKeys12 ZippeyKeys12 deleted the ci-stuff branch April 27, 2025 04:05
@dc-mak
Copy link
Contributor

dc-mak commented Apr 27, 2025

Nice! https://github.com/koalaman/shellcheck?tab=readme-ov-file#testimonials

At first you're like "shellcheck is awesome" but then you're like "wtf are we still using bash"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Related to CI infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants