[CN-exec] Better error messages#329
Merged
rbanerjee20 merged 25 commits intorems-project:mainfrom Sep 24, 2025
Merged
Conversation
rbanerjee20
force-pushed
the
better-error-messages
branch
from
9ec3e08 to
596bcb3
Compare
rbanerjee20
force-pushed
the
better-error-messages
branch
from
adbe781 to
cbca310
Compare
…check failure cases
rbanerjee20
force-pushed
the
better-error-messages
branch
from
e57409a to
e4a8b49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces an experimental "ownership stack mode" to Fulminate, which records (and reports, in case of ownership error) the stack of source locations where ownership was taken for a given byte of memory. Invoked via
--ownership-stack-mode.This augments the value type of the ownership ghost map with a
cn_source_location_stack *, which is only populated when this mode is enabled. This also adds a generic macro-based stack implementation to the Fulminate runtime library.This feature remains experimental as there is a known issue of Fulminate no longer reporting the correct spec source location in error messages (including in this feature, for now) since the change to always preprocess input files under the hood (#111). We hope to resolve this issue imminently in a separate PR.