Skip to content

[Bennet] Fix nested arbitrary<pointer> #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZippeyKeys12 merged 1 commit into from
Jan 28, 2026
Merged

[Bennet] Fix nested arbitrary<pointer> #491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 49 additions & 23 deletions lib/testGeneration/bennet/stage6/convert.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,32 +136,58 @@ module Make (AD : Domain.T) = struct
let (Annot (tm_, (path_vars, last_var), bt, _)) = tm in
match tm_ with
| `Arbitrary ->
let sign, bits = Option.get (BT.is_bits_bt bt) in
let sign_str = match sign with Unsigned -> "UNSIGNED" | Signed -> "SIGNED" in
( [],
[],
mk_expr
(string_call
("BENNET_ARBITRARY_" ^ sign_str)
[ mk_expr
(AilEconst (ConstantInteger (IConstant (Z.of_int bits, Decimal, None))))
]) )
(match bt with
| Loc () -> ([], [], mk_expr (string_call "BENNET_ARBITRARY_POINTER" []))
| Bits (sign, bits) ->
let sign_str = match sign with Unsigned -> "UNSIGNED" | Signed -> "SIGNED" in
( [],
[],
mk_expr
(string_call
("BENNET_ARBITRARY_" ^ sign_str)
[ mk_expr
(AilEconst
(ConstantInteger (IConstant (Z.of_int bits, Decimal, None))))
]) )
| _ ->
failwith
(Printf.sprintf
"Arbitrary: only pointer and bitvector types are supported, got %s"
(Pp.plain (BT.pp bt))))
| `Symbolic -> failwith "TODO"
| `ArbitraryDomain _ ->
let sign, bits = Option.get (BT.is_bits_bt bt) in
let sign_str = match sign with Unsigned -> "UNSIGNED" | Signed -> "SIGNED" in
( [],
[],
mk_expr
(string_call
("BENNET_ARBITRARY_" ^ sign_str)
[ mk_expr
(AilEconst (ConstantInteger (IConstant (Z.of_int bits, Decimal, None))))
]) )
(match bt with
| Loc () -> ([], [], mk_expr (string_call "BENNET_ARBITRARY_POINTER" []))
| Bits (sign, bits) ->
let sign_str = match sign with Unsigned -> "UNSIGNED" | Signed -> "SIGNED" in
( [],
[],
mk_expr
(string_call
("BENNET_ARBITRARY_" ^ sign_str)
[ mk_expr
(AilEconst
(ConstantInteger (IConstant (Z.of_int bits, Decimal, None))))
]) )
| _ ->
failwith
(Printf.sprintf
"ArbitraryDomain: only pointer and bitvector types are supported, got %s"
(Pp.plain (BT.pp bt))))
| `ArbitrarySpecialized ((min_inc, min_ex), (max_inc, max_ex)) ->
let sign, bits = Option.get (BT.is_bits_bt bt) in
let sign_char = match sign with Unsigned -> 'u' | Signed -> 'i' in
let cn_ty = Printf.sprintf "cn_bits_%c%d" sign_char bits in
let cn_ty =
match bt with
| Loc () -> "cn_pointer"
| Bits (sign, bits) ->
let sign_char = match sign with Unsigned -> 'u' | Signed -> 'i' in
Printf.sprintf "cn_bits_%c%d" sign_char bits
| _ ->
failwith
(Printf.sprintf
"ArbitrarySpecialized: only pointer and bitvector types are supported, \
got %s"
(Pp.plain (BT.pp bt)))
in
(* Build argument expressions for bounds - NULL for None *)
let mk_bound_arg = function
| None -> mk_expr (AilEconst ConstantNull)
Expand Down