Added a Dockerfile and spec for a VSCode dev container for CN.#56
Added a Dockerfile and spec for a VSCode dev container for CN.#56ZippeyKeys12 merged 7 commits intorems-project:mainfrom aschwerdfeger-galois:devcontainer
Conversation
|
Can you add this to the Docker CI to make sure it doesn't break in the future? I'm somewhat surprised the existing containers don't do something similar already. |
|
I added a section to |
|
For future reference, long commit headers get cut off in GitHub and git log, so if you can shorten the header, please do: https://github.com/rems-project/cn/blob/main/doc/CONTRIBUTING.md#what-goes-in-a-commit |
.github/workflows/docker.yml
Outdated
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
|
|
||
| - name: Build multi-platform image |
There was a problem hiding this comment.
@aschwerdfeger-galois can you modify this in the same was as this PR suggests? That speeds up the build significantly.
There was a problem hiding this comment.
Done. I modified the new workflow spec to add devcontainer to the matrix alongside redhat and ubuntu, which seems to be fine functionally, although the nomenclature might need some tweaking.
…at' that the CI uses for code style enforcement.
|
@podhrmic If this looks good to you, I'd like to merge |
|
Question: What will be the URL for pulling the dev container image after this is merged? The spec in |
|
ghcr.io/rems-project/cn:release-devcontainer |
|
LGTM. I don't know why the spec testing is failing, but once that is fixed the PR can IMHO be merged. |
|
It's just flaky (#96) |
No description provided.