Skip to content

Added a Dockerfile and spec for a VSCode dev container for CN.#56

Merged
ZippeyKeys12 merged 7 commits intorems-project:mainfrom
aschwerdfeger-galois:devcontainer
Apr 25, 2025
Merged

Added a Dockerfile and spec for a VSCode dev container for CN.#56
ZippeyKeys12 merged 7 commits intorems-project:mainfrom
aschwerdfeger-galois:devcontainer

Conversation

@aschwerdfeger-galois
Copy link
Collaborator

No description provided.

@dc-mak
Copy link
Contributor

dc-mak commented Apr 14, 2025

Can you add this to the Docker CI to make sure it doesn't break in the future? I'm somewhat surprised the existing containers don't do something similar already.

@aschwerdfeger-galois
Copy link
Collaborator Author

I added a section to docker.yml that should put this container through the same motions as the other two.

@dc-mak
Copy link
Contributor

dc-mak commented Apr 15, 2025

For future reference, long commit headers get cut off in GitHub and git log, so if you can shorten the header, please do: https://github.com/rems-project/cn/blob/main/doc/CONTRIBUTING.md#what-goes-in-a-commit

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Build multi-platform image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aschwerdfeger-galois can you modify this in the same was as this PR suggests? That speeds up the build significantly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I modified the new workflow spec to add devcontainer to the matrix alongside redhat and ubuntu, which seems to be fine functionally, although the nomenclature might need some tweaking.

@ZippeyKeys12
Copy link
Collaborator

@podhrmic If this looks good to you, I'd like to merge

@aschwerdfeger-galois
Copy link
Collaborator Author

Question: What will be the URL for pulling the dev container image after this is merged? The spec in devcontainer.json currently has VSCode building the image locally, so we should probably change that to pull the CI-built version instead.

@ZippeyKeys12
Copy link
Collaborator

ghcr.io/rems-project/cn:release-devcontainer

@dc-mak dc-mak closed this in 1d99b68 Apr 25, 2025
@dc-mak dc-mak reopened this Apr 25, 2025
@podhrmic
Copy link

LGTM. I don't know why the spec testing is failing, but once that is fixed the PR can IMHO be merged.

@ZippeyKeys12
Copy link
Collaborator

It's just flaky (#96)

@ZippeyKeys12 ZippeyKeys12 merged commit 4c861f1 into rems-project:main Apr 25, 2025
11 checks passed
@aschwerdfeger-galois aschwerdfeger-galois deleted the devcontainer branch April 25, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants