v0.5.0rc1#14
Merged
Merged
Conversation
cbc7af5 to
9c2f9ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version improves compatibility with
scanpy:n_genesarguments allowing to return only the top N genes per group whenreturn_as_scanpy=True. This allowed to matchscanpy's sorting method (partial sort) resulting in better reproducibility of scanpy results.encode_and_count_groupsalready returns sorted unique perturbation names. This ensures that gene names are sorted the same way everywhere.(numerator + 1.e-9) / (denominator + 1.e-9)to avoid division by zero, and to be more consistent with scanpy's implementation. This has no effect on the ranking of genes, but allows to get finite fold change values for all genes.It also includes some performance improvements:
batch_sizecan grow much larger now.plate3(in RAM) withbatch_size=1024, this reduced memory footprint from 35GB to 1.5GB, and runtime from 1:17 to 0:50 with 8 CPUs.n_threads. With 32 threads, TAHOE'splate3runs in 21 seconds, while eating only 2.5GB of RAM.Also, it adds support for OVO test on lazy CSR (h5-based) datasets, through a specific parallelization scenario where groups are processed one by one.