Conversation
The UnixOperatingSystemMXBean class is only needed to get info related to file descriptors.
The value is stored as 'vm_start_ns' in the CSV output and 'vm.start_ns' in the JSON output. It has no official semantics (unlike 'vm_start_unix_ms'), but allows recovering the nanoTime() value associated with the 'vm_start_unix_ms' value.
ceresek
left a comment
ceresek
left a comment
There was a problem hiding this comment.
LGTM, thanks !
I kinda expected you to come up with some sort of SystemInfo container that would be used to ship information like vmStartNano to the result writers, or even be available as a singleton ... this looks ... just ... straightforward :-)
I thought along those lines, but I realized that so far, we just need to pass a single "special" value (that the writers cannot easily get themselves if they are to have the same value). The writers are independent of each other and with the harness being the sole user and owner of their interfaces, we decide how the interface looks like. If it turns out that we need to provide the writers with more (static) information like this, or if we create another writer that would duplicate the MBean queries the JSON writer does, we can easily change the interface to accept some sort of system info provider. Also, I understood that the sooner this is supported the better :-) |
2 participants
The value is stored as
vm_start_nsin the CSV output andvm.start_nsin the JSON output. It has no official semantics (unlikevm_start_unix_ms), but allows recovering thenanoTime()value associated with thevm_start_unix_msvalue. It also bumps the JSON format version to 6.BTW, only the last commit is the important one, the others are things that I had lying around for quite some time and thought to sneak them in.
Closes #468