Add custom health parameters check#39
Open
gabrielfernandes-codes wants to merge 1 commit intorenatomefi:masterfrom
Open
Add custom health parameters check#39gabrielfernandes-codes wants to merge 1 commit intorenatomefi:masterfrom
gabrielfernandes-codes wants to merge 1 commit intorenatomefi:masterfrom
Conversation
gabrielfernandes-codes
force-pushed
the
allow-custom-params-check
branch
from
facb6cf to
31ac9c6
Compare
Author
|
@renatomefi please let me know what you think about this one. This method was really useful for a project I had worked on as we had a healthz endpoint that would check our external dependencies and output an fpm-status-like page, so it was required a custom controller to be included in the script as well as custom parameters. Tests are commented out as it required #38 to work properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Allow the definition of custom parameters check on status page. Motivation to this change is allow developer to create their own status page to external checks of healthiness and still enjoy the use of this script.
Changes