Merged
Conversation
Refactor IP check logic to set whitelist flag in request state.
Add check for whitelisted requests in suspicious activity detection
Add check for whitelisted requests in cloud provider check.
Add check for whitelisted user agents in the request.
* Simplify pre-commit checks in scheduled lint workflow Removed unnecessary output handling and exit code checks from pre-commit run step. * Disable semgrep in pre-commit configuration Comment out semgrep configuration in pre-commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Whitelisted IPs (those in SecurityConfig.whitelist) were still being subjected to rate limiting, suspicious activity detection, user agent filtering, and cloud provider blocking. This PR ensures that once an IP is confirmed as whitelisted during the IP security check, all downstream checks respect that status and skip enforcement.
Additionally includes small fixes: added PATCH to default CORS methods, Python 3.14 support in Makefile, updated LICENSE copyright, and simplified Makefile help target.
Motivation and Context
When an IP is explicitly whitelisted via SecurityConfig.whitelist, the intent is to trust that IP. However, several security checks (rate limiting, suspicious activity, user agent, cloud provider) had no awareness of whitelist status and would still block or rate-limit whitelisted IPs. This created a confusing experience where whitelisted IPs were not truly whitelisted.
Type of change
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: