peripherals: LC709205F: Replace manual CRC8 with CRCEngine#154
Open
tt2-woo wants to merge 1 commit intorenode:masterfrom
Open
peripherals: LC709205F: Replace manual CRC8 with CRCEngine#154tt2-woo wants to merge 1 commit intorenode:masterfrom
tt2-woo wants to merge 1 commit intorenode:masterfrom
Conversation
The LC709205F model contained a manual, bit-by-bit implementation for calculating the CRC-8 checksum. This change refactors the model to use the centralized and more performant `Antmicro.Renode.Utilities.CRCEngine`. The new `CRCEngine` instance is configured to be functionally identical to the previous implementation (CRC-8/CCITT, polynomial 0x07, no input/output reflection). This improves code quality by: - Removing duplicated code. - Increasing performance through the use of a lookup table. - Enhancing maintainability and readability.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LC709205F model contained a manual, bit-by-bit implementation for calculating the CRC-8 checksum.
This change refactors the model to use the centralized and more performant
Antmicro.Renode.Utilities.CRCEngine. The newCRCEngineinstance is configured to be functionally identical to the previous implementation (CRC-8/CCITT, polynomial 0x07, no input/output reflection).This improves code quality by: