Skip to content

Fix SimpleCache miss issue in Packet.cs with Maximum bound and Queue #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Leeharim-korean wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix SimpleCache miss issue in Packet.cs with Maximum bound and Queue #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 27 additions & 4 deletions src/Emulator/Main/Utilities/Collections/SimpleCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ namespace Antmicro.Renode.Utilities.Collections
{
public class SimpleCache
{

public int MaxEntries { get; set; } = 5000; // the Maximum bound I use

public R Get<T1, R>(T1 parameter, Func<T1, R> generator)
{
if(generator == null)
Expand All @@ -20,13 +23,20 @@ public R Get<T1, R>(T1 parameter, Func<T1, R> generator)
var obj = new CacheObject<T1, Object, Func<T1, R>>(generator, parameter);
if(simpleCache.TryGetValue(obj, out var result))
{
this.CacheHits = this.CacheHits + 1;
CacheHits++;
return (R)result;
}

this.CacheMisses = this.CacheMisses + 1;
CacheMisses++;
var generated = generator(parameter);
if(simpleCache.Count >= MaxEntries)
{
var oldestKey = insertionOrderQueue.Dequeue();
simpleCache.Remove(oldestKey);
}

simpleCache[obj] = generated;
insertionOrderQueue.Enqueue(obj);
return generated;
}

Expand All @@ -39,12 +49,22 @@ public R Get<T1, T2, R>(T1 parameterT1, T2 parameterT2, Func<T1, T2, R> generato
var obj = new CacheObject<T1, T2, Func<T1, T2, R>>(generator, parameterT1, parameterT2);
if(simpleCache.TryGetValue(obj, out var result))
{
this.CacheHits = this.CacheHits + 1;
CacheHits++;

return (R)result;
}
this.CacheMisses = this.CacheMisses + 1;

CacheMisses++;
var generated = generator(parameterT1, parameterT2);

if(simpleCache.Count >= MaxEntries)
{
var oldestKey = insertionOrderQueue.Dequeue();
simpleCache.Remove(oldestKey);
}

simpleCache[obj] = generated;
insertionOrderQueue.Enqueue(obj);
return generated;
}

Expand All @@ -53,6 +73,7 @@ public void ClearCache()
CacheMisses = 0;
CacheHits = 0;
simpleCache.Clear();
insertionOrderQueue.Clear();
}

public ulong CacheMisses { get; private set; }
Expand All @@ -62,6 +83,8 @@ public void ClearCache()
public int CacheSize { get { return simpleCache.Count; } }

private readonly Dictionary<object, object> simpleCache = new Dictionary<object, object>();

private readonly Queue<object> insertionOrderQueue = new Queue<object>();

private struct CacheObject<T1, T2, R>
{
Expand Down