-
Notifications
You must be signed in to change notification settings - Fork 7
Fix chained expressions #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 73cd84bClick to view benchmark
|
Benchmark for d82248eClick to view benchmark
|
Benchmark for bcfdb47Click to view benchmark
|
So this seems ok, added some tests, found and fixed a bug in the meantime. If it looks good we should merge it as I have other stuff in the works that rely on this PR. |
emuell
approved these changes
May 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me. Will do more testing after this got merged...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chained expressions were generating unexpectedly thrown away results thanks to the way they were parsed, fixing that here.
Also did a bit of cleanup by separated the Target, Bjorklund and Degrade operators from Dynamic/Dynamic Op/Expression, as they were treated special anyway, this makes the types better reflect the behaviour and leads to a bit less branching at the cost of a few more types.
A few more test cases would be nice to add before merge.