Fix hanging notes in playground #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when preparing a new script (sequence) for playback, pass the previously played sequence along - run the previously played sequence a full step to apply note offs only, shutting down still playing notes - remaining playing notes which did not stop within a bar in the old sequence get stopped immediately
`Continue` mode may still be useful in some rare cases, but definitely should not be the default action.
emuell
force-pushed
the
fix/hanging-notes-on-live-edits
branch
from
93fc84b to
bfe31c2
Compare
Benchmark for d375f86Click to view benchmark
|
|
I cannot replicate it anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exchanging a player's sequence (a single pattern in the playground), run the previously played back sequence for a full time unit's step to apply note stops only. If there are still playing notes after the previous sequence has been played back, stop them forcefully.
fixes #89
@unlessgames could you quicky check if you can still replicate this?
Will merge #87 afterwards, as both have changes in player.rs which may conflict.