fix inverse behaviour for sample assignment in cycles #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for e06ca3cClick to view benchmark
|
Benchmark for b9b4bb2Click to view benchmark
|
|
+1 for consistency. Looks fine to me, and I agree that this can be treated as a bug fix. |
Benchmark for 81b2f1fClick to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it seems like I've missed this when discussing #54 and haven't actually used sample properties much but I feel that this should actually work the same way as the other assignments.
Right now, the outer index overrides the inner one, which is the opposite of what happens with volumes and the rest.
If multiple assigned samples could stack when playing maybe this would make more sense (but there is already stacking syntax so that's not as useful).
Of course, this is a breaking change but I think one that may not have been used much and that arguably makes the notation more useful and consistent. I'd consider the current implementation a bug.