Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update github action runners #324

Closed
wants to merge 1 commit into from
Closed

chore(deps): update github action runners #324

wants to merge 1 commit into from

Conversation

HonkingGoose
Copy link
Contributor

@HonkingGoose HonkingGoose commented Oct 15, 2020

Changes:

  • Update actions/checkout to 2.3.3
  • Update wagoid/commitlint-github-action to 1.8.0
  • Update actions/setup-node to 1.4.4
  • Update actions/create-release to 1.1.4

Context:

This pull request bumps all GitHub Action runners to the latest stable version that is in range.

I noticed all the GitHub action runners are using outdated versions. I don't know if this is by design or not.
I don't know if Renovate can check for regular GitHub Actions updates?

The wagoid/commitlint-github-action actually has a 2.x release with breaking changes.

Quote from v2.0.0 changelog:

  • GITHUB_TOKEN env var is now ignored. In case a custom token is needed,
    it'll be necessary to pass it via the token input from now on.
  • this includes breaking changes from commitlint v9,
    like the fact that improvement type is now rejected in @commitlint/config-conventional.

Release logs for included version upgrades:

https://github.com/actions/checkout/releases/tag/v2.3.3
https://github.com/wagoid/commitlint-github-action/releases/tag/v1.8.0
https://github.com/actions/setup-node/releases/tag/v1.4.4
https://github.com/actions/create-release/releases/tag/v1.1.4


EDIT: Force pushed a amended commit with a commit message that passes the commit-lint check. 🤓
Also I hope I'm using the right template, I don't know if this is a chore(deps) or a fix(deps) kind of change.

@HonkingGoose HonkingGoose changed the title chore(deps): Update GitHub Action runners chore(deps): update github action runners Oct 15, 2020
- Update actions/checkout to 2.3.3
- Update wagoid/commitlint-github-action to 1.8.0
- Update actions/setup-node to 1.4.4
- Update actions/create-release to 1.1.4
@viceice
Copy link
Member

viceice commented Oct 16, 2020

Let's wait for renovatebot/renovate#7434. This will enable renovate for github actions.

@viceice
Copy link
Member

viceice commented Oct 16, 2020

ref renovatebot/presets-internal#5

@viceice
Copy link
Member

viceice commented Oct 16, 2020

closing this in favor of renovate auto updating, see #31

@viceice viceice closed this Oct 16, 2020
@HonkingGoose HonkingGoose deleted the patch-1 branch October 16, 2020 06:44
@HonkingGoose
Copy link
Contributor Author

Thanks for responding!
I was thinking, at least let them know the actions are out of date, so that you can deal with that if you want.

Cool that you're working on GitHub Action support! 😄 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants