Skip to content

Comments

feat(replacements): add express-response-middleware#39890

Open
marklai1998 wants to merge 7 commits intorenovatebot:mainfrom
marklai1998:patch-1
Open

feat(replacements): add express-response-middleware#39890
marklai1998 wants to merge 7 commits intorenovatebot:mainfrom
marklai1998:patch-1

Conversation

@marklai1998
Copy link

@marklai1998 marklai1998 commented Dec 10, 2025

Changes

Replace express-mung with a maintained fork

Original: https://github.com/richardschneider/express-mung (https://www.npmjs.com/package/express-mung)
Replacement: https://github.com/marklai1998/express-response-middleware (https://www.npmjs.com/package/express-response-middleware)

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository:

@cla-assistant
Copy link

cla-assistant bot commented Dec 10, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add links to packages to PR description

@marklai1998
Copy link
Author

please add links to packages to PR description

Updated

@marklai1998 marklai1998 requested a review from viceice December 15, 2025 16:25
viceice
viceice previously approved these changes Dec 15, 2025
@marklai1998 marklai1998 force-pushed the patch-1 branch 2 times, most recently from d72fb54 to 477ad4c Compare January 2, 2026 19:58
@marklai1998
Copy link
Author

@viceice any plan to merge this?

@marklai1998
Copy link
Author

@viceice @RahulGautamSingh any plan of merging this? it has been a month

@RahulGautamSingh RahulGautamSingh added the auto:no-pings Reminder to users who "chase up" or hassle about topics label Jan 30, 2026
@github-actions
Copy link
Contributor

Hi there,

Please do not post comments like: "Any update on this?" or "When will this be fixed?".

If you're asking because you want to know if there's been some progress, then please know that we work in the open in this repo. If there was an update to this Discussion or Issue, you would see it already. So please don't ask "just in case".

If you're asking because you want to get our attention, then please don't do that either. It wastes maintainer time and pollutes the repo. You're welcome to fix issues yourself, hire someone to help you, or wait for someone else to do the work. You're not welcome to post the equivalent of "Hey, someone else should really do something about this".

If you are a paying Mend.io customer, contact your support or customer success representative, and tell them this issue is important to you.

We expect everyone to follow these rules, no matter if you use the free tiers, or are a paying Mend customer. Please read our Code of Conduct, how we prioritize work to learn more about how we prioritize what to work on.

Thanks, the Renovate team

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it expected that this rule isn't enabled with the others? see preset at beginning of the file

@marklai1998
Copy link
Author

is it expected that this rule isn't enabled with the others? see preset at beginning of the file

Updated

Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a working reproduction.

@marklai1998
Copy link
Author

marklai1998 commented Feb 4, 2026

@RahulGautamSingh wdym of working reproduction, you mean the package replacement itself?

@RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh wdym of working reproduction, you mean the package replacement itself?

No, I mean create a public github repo with the old dep, and in the renovate config add this replacement preset and run renovate on it. This should create a replacement PR.

@marklai1998
Copy link
Author

@RahulGautamSingh wdym of working reproduction, you mean the package replacement itself?

No, I mean create a public github repo with the old dep, and in the renovate config add this replacement preset and run renovate on it. This should create a replacement PR.

I'm not trying to be difficult, but may I know why it is needed
It's a static config file, and it follows the same syntax, so it should run the same way as other rules.
I don't see a "reproduction" is needed for other replacements PR's either

I'll try to do it in my spare time. Thanks anyway!!

@marklai1998 marklai1998 requested a review from viceice February 22, 2026 17:43
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Rahul-renovate-testing/test-express-middleware/pulls

Fork this repro and make it work pls.

That's why we ask for a test repo so we can verify the changes you made actually do the work.

@marklai1998
Copy link
Author

https://github.com/Rahul-renovate-testing/test-express-middleware/pulls

Fork this repro and make it work pls.

That's why we ask for a test repo so we can verify the changes you made actually do the work.

Updated, sth to do with pre 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto:no-pings Reminder to users who "chase up" or hassle about topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants