Skip to content

Comments

fix(vulnerabilities): fix CJS interop for ae-cvss-calculator import#41337

Open
Churro wants to merge 2 commits intorenovatebot:mainfrom
Churro:fix/osv-aecvss-jcs
Open

fix(vulnerabilities): fix CJS interop for ae-cvss-calculator import#41337
Churro wants to merge 2 commits intorenovatebot:mainfrom
Churro:fix/osv-aecvss-jcs

Conversation

@Churro
Copy link
Collaborator

@Churro Churro commented Feb 19, 2026

Changes

#40756 added a type cast to destructure fromVector that didn't work because ae-cvss-calculator is a CJS module. It led to _aeCvss.fromVector being undefined, causing TypeError: fromVector is not a function.

The fix ensures that the function is searched where it actually lives.

Context

Please select one of the following:

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository:

@github-actions github-actions bot requested a review from viceice February 19, 2026 20:41
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cast to any is also a bad idea, we totally loose type safety.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants