Skip to content

Comments

fix(gomod): support major version on replaces with the same Go module#41359

Draft
jamietanna wants to merge 2 commits intomainfrom
fix/gomod-replace
Draft

fix(gomod): support major version on replaces with the same Go module#41359
jamietanna wants to merge 2 commits intomainfrom
fix/gomod-replace

Conversation

@jamietanna
Copy link
Contributor

@jamietanna jamietanna commented Feb 20, 2026

Changes

As noted in #41260, if a Go module is using a replace with both
modules with the same name, the major upgrade fails to produce a valid
go.mod, as the replace will still partially reference the old
package.

Context

Please select one of the below:

  • This closes an existing Issue: Closes #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository: JamieTanna-Mend-testing/renovate-iss-41260-gomod-bug-test#1

We've already got a test that covers the usage of a `replace` with a
`major` update.
As noted in #41260, if a Go module is using a `replace` with both
modules with the same name, the major upgrade fails to produce a valid
`go.mod`, as the `replace` will still partially reference the old
package.
Base automatically changed from test/gomod to main February 20, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant