Skip to content

Comments

feat(instrumentation): allow disabling cloud detectors#41401

Open
viceice wants to merge 6 commits intomainfrom
feat/otel-detector-disable
Open

feat(instrumentation): allow disabling cloud detectors#41401
viceice wants to merge 6 commits intomainfrom
feat/otel-detector-disable

Conversation

@viceice
Copy link
Member

@viceice viceice commented Feb 23, 2026

Changes

I like to supress the false positives in traces because of the cloud detection which always fails in most self-hosted scenarios.

Context

Please select one of the following:

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository:

Copy link
Contributor

@jamietanna jamietanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viceice
Copy link
Member Author

viceice commented Feb 23, 2026

Should be covered already with https://docs.renovatebot.com/self-hosted-configuration/#usecloudmetadataservices

no, that is too late, instrumentation is already done at when that option is processed

@jamietanna
Copy link
Contributor

#38604 is the work to track this request - we've recommended only using process.env.USE_CLOUD_METADATA_SERVICES (in the future) so we could use that here?

@viceice
Copy link
Member Author

viceice commented Feb 23, 2026

#38604 is the work to track this request - we've recommended only using process.env.USE_CLOUD_METADATA_SERVICES (in the future) so we could use that here?

OK, will redo my pr and take the solution of

@viceice viceice force-pushed the feat/otel-detector-disable branch from b43d91f to 244165c Compare February 23, 2026 16:03
@viceice viceice requested a review from jamietanna February 23, 2026 16:04
@jamietanna jamietanna changed the title feat(otel): allow disabling cloud detectors feat(instrumentation): allow disabling cloud detectors Feb 23, 2026
viceice and others added 2 commits February 23, 2026 19:11
Co-authored-by: Jamie Tanna <jamie.tanna@mend.io>
@viceice viceice requested a review from jamietanna February 24, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(instrumentation): Do not discover Cloud environment when using useCloudMetadataServices=false

3 participants