Skip to content

Comments

fix(util): don't warn if a file contains only a Byte Order Mark (BOM)#41416

Merged
jamietanna merged 1 commit intomainfrom
fix/41381
Feb 23, 2026
Merged

fix(util): don't warn if a file contains only a Byte Order Mark (BOM)#41416
jamietanna merged 1 commit intomainfrom
fix/41381

Conversation

@jamietanna
Copy link
Contributor

Changes

As noted in #41381, it's common for a Byte Order Mark (BOM) Unicode
character to exist in a codebase that's used on Windows.

If we only find a BOM, we will report a TRACE log instead of the WARN,
but if any other characters are found, we'll continue with our WARN.

Context

Please select one of the below:

  • This closes an existing Issue: Closes #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository: https://github.com/Particular/Particular.Packaging

As noted in #41381, it's common for a Byte Order Mark (BOM) Unicode
character to exist in a codebase that's used on Windows.

If we only find a BOM, we will report a TRACE log instead of the WARN,
but if any other characters are found, we'll continue with our WARN.
@github-actions github-actions bot requested a review from viceice February 23, 2026 14:14
@jamietanna jamietanna added this pull request to the merge queue Feb 23, 2026
Merged via the queue into main with commit 7c7330b Feb 23, 2026
46 checks passed
@jamietanna jamietanna deleted the fix/41381 branch February 23, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants