-
Notifications
You must be signed in to change notification settings - Fork 66
added: Initial part of the GooglePlay consumable support #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
neyunse
wants to merge
8
commits into
renpy:master
Choose a base branch
from
neyunse:play-consumables-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
87b3bfb
added: Initial part of the GooglePlay consumable support
neyunse 7a270d6
fix: added an small sleep inside consumePurchase
neyunse bcc54e1
rm: removed unnecessary code
neyunse 297d8ec
Update rapt/prototype/renpyiap/src/main/java/org/renpy/iap/PlayStore.…
neyunse 8926706
Update rapt/prototype/renpyiap/src/main/java/org/renpy/iap/PlayStore.…
neyunse 3b8d8e1
Update rapt/prototype/renpyiap/src/main/java/org/renpy/iap/PlayStore.…
neyunse a002cf3
Update rapt/prototype/renpyiap/src/main/java/org/renpy/iap/PlayStore.…
neyunse f314c49
rm: removed HashSet
neyunse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the error case is hit (line 244), the error is logged but the
finishedflag is not set until after the sleep. Additionally, if the query fails but no matching purchase is found,finishedis set totrueat line 259, but if a matching purchase is found and consumption begins, the early return at line 255 means the line 259 will never execute. This is correct, but the error logging at line 244 should include more details about the failure (e.g.,billingResult.getDebugMessage()).