Skip to content

Add ruleset configuration #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CuddlyBunion341
Copy link
Contributor

@CuddlyBunion341 CuddlyBunion341 commented May 12, 2025

TICKET-23953

Rulesets are a new feature of GitHub. They are the preffered way of defining protection rules compared to the classic options.

The new Rulesets offer more flexibility and control compared to the "Classic branch protection rules".
We propose that we should embrace the new standard for upcoming repositories.

@CuddlyBunion341 CuddlyBunion341 self-assigned this May 12, 2025
Copy link
Member

@coorasse coorasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions:

  • is this an improvement in any direction? the new rulesets offer more flexibility, but if we don't use it, does it mean more complexity for us and we would be perfectly fine with the existing branch protection?
  • we were trying to fix the problem that we can push to develop and we don't want that, while allowing everyone to still bypass checks and merge if they want. Is this now tackled?

@hunchr
Copy link
Member

hunchr commented May 13, 2025

does it mean more complexity for us

it's very similar to the classic branch protection. it's not more complex.

we were trying to fix the problem that we can push to develop and we don't want that, while allowing everyone to still bypass checks and merge if they want. Is this now tackled?

yes, you can uncheck Require status checks to pass if you want to merge a failing pr

@hunchr hunchr requested a review from coorasse May 14, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants