Skip to content

fix: solana send transaction - #5439

Merged
0xmkh merged 5 commits into
mainfrom
fix/solana-write-transaction
Jan 5, 2026
Merged

fix: solana send transaction#5439
0xmkh merged 5 commits into
mainfrom
fix/solana-write-transaction

Conversation

@0xmkh

@0xmkh 0xmkh commented Jan 5, 2026

Copy link
Copy Markdown
Collaborator

Description

Fixed an issue where you could not send custom instruction transactions on solana

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot

changeset-bot Bot commented Jan 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: bb91a95

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Jan 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
appkit-basic-html Ready Ready Preview, Comment Jan 5, 2026 4:52pm
appkit-demo Ready Ready Preview, Comment Jan 5, 2026 4:52pm
appkit-gallery Ready Ready Preview, Comment Jan 5, 2026 4:52pm
appkit-headless-sample-app Ready Ready Preview, Comment Jan 5, 2026 4:52pm
appkit-laboratory Ready Ready Preview, Comment Jan 5, 2026 4:52pm
10 Skipped Deployments
Project Deployment Review Updated (UTC)
appkit-basic-example Ignored Ignored Jan 5, 2026 4:52pm
appkit-basic-sign-client-example Ignored Ignored Jan 5, 2026 4:52pm
appkit-basic-up-example Ignored Ignored Jan 5, 2026 4:52pm
appkit-ethers5-bera Ignored Ignored Jan 5, 2026 4:52pm
appkit-nansen-demo Ignored Ignored Jan 5, 2026 4:52pm
appkit-vue-solana Ignored Ignored Jan 5, 2026 4:52pm
appkit-wagmi-cdn-example Ignored Ignored Jan 5, 2026 4:52pm
ethereum-provider-wagmi-example Ignored Ignored Jan 5, 2026 4:52pm
next-wagmi-solana-bitcoin-example Ignored Ignored Jan 5, 2026 4:52pm
vue-wagmi-example Ignored Ignored Jan 5, 2026 4:52pm

@github-actions

github-actions Bot commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

Visual Regression Test Results ✅ Passed

⚠️ 7 visual change(s) detected

Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=565
Storybook Preview: https://6493191bf4b10fed8ca7353f-jqcozkhawn.chromatic.com/

👉 Please review the visual changes in Chromatic and accept or reject them.

@github-actions

github-actions Bot commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size Check

All bundles are within size limits

📊 View detailed bundle sizes

> @reown/appkit-monorepo@1.7.1 size /home/runner/work/appkit/appkit


> size-limit


[baseline-browser-mapping] The data in this module is over two months old. To ensure accurate Baseline data, please update: npm i baseline-browser-mapping@latest -D

@reown/appkit - Main Entry
Size limit:   80 kB
Size:         75.01 kB with all dependencies, minified and gzipped
Loading time: 1.5 s    on slow 3G
Running time: 792 ms   on Snapdragon 410
Total time:   2.3 s
@reown/appkit/react
Size limit:   235 kB
Size:         233.03 kB with all dependencies, minified and gzipped
Loading time: 4.6 s     on slow 3G
Running time: 1.7 s     on Snapdragon 410
Total time:   6.2 s
@reown/appkit/vue
Size limit:   80 kB
Size:         75.01 kB with all dependencies, minified and gzipped
Loading time: 1.5 s    on slow 3G
Running time: 375 ms   on Snapdragon 410
Total time:   1.9 s
@reown/appkit-scaffold-ui
Size limit:   220 kB
Size:         212.49 kB with all dependencies, minified and gzipped
Loading time: 4.2 s     on slow 3G
Running time: 787 ms    on Snapdragon 410
Total time:   5 s
@reown/appkit-ui
Size limit:   500 kB
Size:         13.15 kB with all dependencies, minified and gzipped
Loading time: 257 ms   on slow 3G
Running time: 59 ms    on Snapdragon 410
Total time:   315 ms

@github-actions

github-actions Bot commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.5% 39303 / 50065
🔵 Statements 78.5% 39303 / 50065
🔵 Functions 76.19% 4231 / 5553
🔵 Branches 86.75% 9546 / 11003
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/adapters/bitcoin/src/adapter.ts 84.16% 84.74% 70.96% 84.16% 67-80, 83, 199-200, 305-321, 402-403, 410-411, 443-444, 456-457, 508-509, 565-568, 572-606, 610-611
packages/adapters/ethers/src/client.ts 65.49% 75.96% 63.63% 65.49% 109-110, 123-124, 147-148, 162-185, 198-234, 240-241, 248-265, 294-295, 390-415, 418-423, 436-437, 447-468, 474-476, 479-480, 507, 536-537, 545-546, 574-579, 598-644, 651-652, 674, 703-704, 715-716, 750-751, 755, 770-771, 788-793, 802-820, 826-827, 836-837, 848-849, 855-867
packages/adapters/ethers5/src/client.ts 60.64% 73.68% 63.63% 60.64% 69-90, 106-107, 120-121, 144-145, 159-182, 195-231, 234-235, 241-242, 249-266, 385-410, 413-418, 431-432, 442-463, 469-471, 474-475, 502, 531-532, 540-541, 569-574, 578-624, 646-647, 669, 698-699, 711-712, 749-750, 754, 768-793, 801-819, 825-826, 835-836, 847-848, 854-866
packages/adapters/solana/src/client.ts 66.02% 76.08% 39.47% 66.02% 103-110, 143-146, 149-212, 215-216, 219-220, 223-224, 227-230, 233-241, 248-249, 259-279, 287-288, 293-299, 324-337, 341-342, 345-346, 354-355, 360-367, 387-400, 423-426, 450-451, 461-462, 481-482, 489-490, 514-515, 519-520, 523-524, 561-565, 589-590, 613-619
packages/adapters/ton/src/adapter.ts 91.45% 92.64% 81.48% 91.45% 64-77, 80, 109-110, 129-130, 178-179, 201-202, 315-316
packages/adapters/wagmi/src/client.ts 76.06% 66.66% 79.54% 76.06% 124-125, 130-131, 142-144, 146, 208-209, 249-252, 362-363, 377, 387-388, 401-402, 479-480, 492-493, 534-535, 552-567, 581-598, 618-619, 632-641, 652-653, 657-658, 663-695, 714-723, 727-733, 736-747, 756-757, 768-769, 790-792, 806-807, 820-821, 836-837, 880-881, 905-906, 914-915, 920-921, 928-929, 937-938, 943-944, 953-954, 962-963, 968-969, 975-997, 1000-1013
packages/appkit/src/client/appkit-base-client.ts 71.35% 85.58% 74.89% 71.35% 183-189, 209, 222-225, 228, 240-241, 247-248, 251, 260, 307-308, 354-355, 393-394, 396-397, 402-403, 483-484, 520-526, 597-598, 620-635, 638, 672-673, 676, 717-721, 728-729, 732-733, 738-739, 750-773, 782-783, 800-820, 824-845, 848-874, 877-883, 886-892, 895-901, 904-910, 913-923, 926-932, 935-942, 956-965, 968-974, 977-978, 981-982, 1001-1002, 1025-1065, 1072-1084, 1090-1117, 1120-1130, 1162-1163, 1188-1189, 1194, 1209-1225, 1239, 1243-1251, 1282-1283, 1302-1305, 1309-1310, 1312-1313, 1347-1349, 1353-1374, 1379-1380, 1388-1389, 1391-1392, 1486-1487, 1499-1500, 1505, 1528-1533, 1580, 1601-1602, 1611, 1613-1629, 1634, 1680-1681, 1693-1704, 1750-1763, 1808, 1814-1818, 1839-1854, 1857-1858, 1884-1887, 1923-1942, 1974, 2017-2018, 2024-2050, 2271-2272, 2309-2310, 2313-2314, 2330-2333, 2336-2337, 2357-2358, 2361-2362, 2374-2384, 2404-2405, 2408-2415, 2419-2420, 2434, 2442, 2447, 2452-2471, 2474-2483, 2490-2495, 2513-2514, 2517-2518, 2525-2526, 2565-2566, 2637-2638, 2641-2642, 2645-2648, 2651-2652, 2655-2656, 2659-2660, 2663-2664, 2667-2671, 2680-2689, 2698-2709, 1372, 2454-2475
packages/appkit/src/universal-adapter/client.ts 52.91% 58.06% 34.21% 52.91% 18-19, 33-42, 61-64, 99-103, 109, 111-115, 121, 131-164, 173-176, 179-182, 185-188, 190-193, 196-197, 200-201, 204-205, 208-209, 212-213, 216-217, 220-227, 240, 244-247, 263-264, 272-34, 132-186
packages/controllers/src/controllers/ConnectionController.ts 84.7% 87.6% 52.68% 84.7% 176, 235-239, 242-246, 288-292, 300-301, 308-327, 342, 346, 350, 354, 358, 362, 366, 370, 374, 378, 461, 465, 487-491, 506-508, 519-520, 555-556, 566-567, 569-570, 578-579, 581-582, 601-602
packages/controllers/src/controllers/AdapterController/ChainAdapterBlueprint.ts 70.6% 85.29% 73.52% 70.6% 144-155, 237-238, 242-243, 266-270, 276-279, 309-310, 347-348, 361-362, 524-551, 564-592, 610-611, 624-653, 662-663, 778-779, 300-562
packages/pay/src/controllers/PayController.ts 88.65% 91.89% 83.6% 88.65% 197, 271-272, 320, 399-412, 553-558, 672-689, 693-723, 727-745, 831-832, 904
Generated in workflow #16599 for commit bb91a95 by the Vitest Coverage Report Action

@0xmkh 0xmkh changed the title fix: solana write transaction fix: solana send transaction Jan 5, 2026
@0xmkh
0xmkh enabled auto-merge January 5, 2026 17:05
@0xmkh
0xmkh disabled auto-merge January 5, 2026 17:06
@0xmkh
0xmkh merged commit 1af3ed8 into main Jan 5, 2026
44 checks passed
@0xmkh
0xmkh deleted the fix/solana-write-transaction branch January 5, 2026 17:06
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant