fix: use correct SLIP-44 coin type for BNB on Binance chain by svenvoskamp · Pull Request #5506 · reown-com/appkit

svenvoskamp · 2026-01-30T11:27:22Z

Summary

Fixed wrong SLIP-44 coin type for BNB on Binance chain (chainId 56)
Changed from eip155:56/slip44:60 (Ethereum) to eip155:56/slip44:714 (BNB)
Also fixed for opBNB (chainId 204)

Problem

When calling reown_getExchanges for BNB on Binance chain, the API returned empty exchanges because the code generated slip44:60 (Ethereum's coin type) instead of slip44:714 (BNB's coin type).

Solution

Added EVM_NATIVE_SLIP44_OVERRIDES map to handle chain-specific SLIP-44 coin types for native tokens. Updated formatCaip19Asset in both ExchangeUtil.ts and AssetUtil.ts to use the override map.

Test plan

Added unit tests for BNB native asset formatting on Binance Smart Chain
Added unit tests for BNB native asset formatting on opBNB
Added unit tests to verify ERC20 tokens are not affected
All existing tests pass

🤖 Generated with Claude Code

When calling reown_getExchanges for BNB on Binance chain (chainId 56), the code was generating the wrong CAIP-19 asset identifier using Ethereum's SLIP-44 coin type (60) instead of BNB's (714). This caused the API to return empty exchanges because there was no asset mapping for slip44:60 on Binance chain. Added EVM_NATIVE_SLIP44_OVERRIDES map to handle chain-specific SLIP-44 coin types for native tokens on BNB chains (56 and 204/opBNB). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

vercel · 2026-01-30T11:27:23Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
appkit-basic-html	Ready	Preview, Comment	Feb 2, 2026 2:58pm
appkit-demo	Ready	Preview, Comment	Feb 2, 2026 2:58pm
appkit-gallery	Ready	Preview, Comment	Feb 2, 2026 2:58pm
appkit-headless-sample-app	Ready	Preview, Comment	Feb 2, 2026 2:58pm
appkit-laboratory	Ready	Preview, Comment	Feb 2, 2026 2:58pm

10 Skipped Deployments

Project	Deployment	Updated (UTC)
appkit-basic-example	Ignored	Feb 2, 2026 2:58pm
appkit-basic-sign-client-example	Ignored	Feb 2, 2026 2:58pm
appkit-basic-up-example	Ignored	Feb 2, 2026 2:58pm
appkit-ethers5-bera	Ignored	Feb 2, 2026 2:58pm
appkit-nansen-demo	Ignored	Feb 2, 2026 2:58pm
appkit-vue-solana	Ignored	Feb 2, 2026 2:58pm
appkit-wagmi-cdn-example	Ignored	Feb 2, 2026 2:58pm
ethereum-provider-wagmi-example	Ignored	Feb 2, 2026 2:58pm
next-wagmi-solana-bitcoin-example	Ignored	Feb 2, 2026 2:58pm
vue-wagmi-example	Ignored	Feb 2, 2026 2:58pm

linear · 2026-01-30T11:27:25Z

REOWN-4419 [Bug] [Walbi] Usign the wrong asset for BNB when calling reown_getExchanges

changeset-bot · 2026-01-30T11:27:26Z

⚠️ No Changeset found

Latest commit: 48aa2e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-01-30T11:29:26Z

Visual Regression Test Results ✅ Passed

⚠️ 15 visual change(s) detected

Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=719
Storybook Preview: https://6493191bf4b10fed8ca7353f-egzletzlmf.chromatic.com/

👉 Please review the visual changes in Chromatic and accept or reject them.

github-actions · 2026-01-30T11:33:46Z

📦 Bundle Size Check

✅ All bundles are within size limits

📊 View detailed bundle sizes

> @reown/appkit-monorepo@1.7.1 size /home/runner/work/appkit/appkit

> size-limit

@reown/appkit - Main Entry
Size limit:   80 kB
Size:         75.49 kB with all dependencies, minified and gzipped
Loading time: 1.5 s    on slow 3G
Running time: 254 ms   on Snapdragon 410
Total time:   1.8 s
@reown/appkit/react
Size limit:   235 kB
Size:         233.37 kB with all dependencies, minified and gzipped
Loading time: 4.6 s     on slow 3G
Running time: 1.1 s     on Snapdragon 410
Total time:   5.7 s
@reown/appkit/vue
Size limit:   80 kB
Size:         75.49 kB with all dependencies, minified and gzipped
Loading time: 1.5 s    on slow 3G
Running time: 432 ms   on Snapdragon 410
Total time:   2 s
@reown/appkit-scaffold-ui
Size limit:   220 kB
Size:         213.39 kB with all dependencies, minified and gzipped
Loading time: 4.2 s     on slow 3G
Running time: 774 ms    on Snapdragon 410
Total time:   5 s
@reown/appkit-ui
Size limit:   500 kB
Size:         13.16 kB with all dependencies, minified and gzipped
Loading time: 258 ms   on slow 3G
Running time: 44 ms    on Snapdragon 410
Total time:   301 ms

github-actions · 2026-01-30T11:35:53Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	78.66%	39486 / 50197
🔵	Statements	78.66%	39486 / 50197
🔵	Functions	76.34%	4250 / 5567
🔵	Branches	86.73%	9615 / 11085

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/controllers/src/utils/ExchangeUtil.ts	99.57%	94.73%	76.92%	99.57%	186
packages/pay/src/utils/AssetUtil.ts	45.74%	88.88%	16.66%	45.74%	52-53, 61-64, 67-97, 100-112, 125-133

Generated in workflow #16798 for commit 48aa2e5 by the Vitest Coverage Report Action

Move comments above code lines instead of inline to satisfy no-inline-comments and line-comment-position ESLint rules. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

vercel Bot deployed to Preview – appkit-basic-html January 30, 2026 11:29 View deployment

vercel Bot deployed to Preview – appkit-gallery January 30, 2026 11:29 View deployment

vercel Bot deployed to Preview – appkit-headless-sample-app January 30, 2026 11:30 View deployment

vercel Bot deployed to Preview – appkit-demo January 30, 2026 11:31 View deployment

vercel Bot deployed to Preview – appkit-laboratory January 30, 2026 11:32 View deployment

fix: move inline comments above code to fix lint errors

48aa2e5

Move comments above code lines instead of inline to satisfy no-inline-comments and line-comment-position ESLint rules. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

vercel Bot deployed to Preview – appkit-gallery February 2, 2026 14:55 View deployment

vercel Bot deployed to Preview – appkit-basic-html February 2, 2026 14:55 View deployment

vercel Bot deployed to Preview – appkit-headless-sample-app February 2, 2026 14:56 View deployment

vercel Bot deployed to Preview – appkit-laboratory February 2, 2026 14:57 View deployment

vercel Bot deployed to Preview – appkit-demo February 2, 2026 14:58 View deployment

0xmkh approved these changes Feb 3, 2026

View reviewed changes

svenvoskamp added this pull request to the merge queue Feb 3, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 3, 2026

svenvoskamp added this pull request to the merge queue Feb 3, 2026

Merged via the queue into main with commit 31a0f23 Feb 3, 2026
63 of 64 checks passed

svenvoskamp deleted the REOWN-4419 branch February 3, 2026 10:16

github-actions Bot locked and limited conversation to collaborators Feb 3, 2026

Navigation Menu

Uh oh!

fix: use correct SLIP-44 coin type for BNB on Binance chain - #5506

fix: use correct SLIP-44 coin type for BNB on Binance chain#5506
svenvoskamp merged 2 commits into
mainfrom
REOWN-4419

svenvoskamp commented Jan 30, 2026

Uh oh!

vercel Bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

linear Bot commented Jan 30, 2026

Uh oh!

changeset-bot Bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

svenvoskamp commented Jan 30, 2026

Summary

Problem

Solution

Test plan

Uh oh!

vercel Bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear Bot commented Jan 30, 2026

Uh oh!

changeset-bot Bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual Regression Test Results ✅ Passed

Uh oh!

github-actions Bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Bundle Size Check

Uh oh!

github-actions Bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented Jan 30, 2026 •

edited

Loading

changeset-bot Bot commented Jan 30, 2026 •

edited

Loading

github-actions Bot commented Jan 30, 2026 •

edited

Loading

github-actions Bot commented Jan 30, 2026 •

edited

Loading

github-actions Bot commented Jan 30, 2026 •

edited

Loading