fix: show "Exchange" label instead of "Wallet" when exchange is selected in pay loading view - #5543
Conversation
…in pay loading view Co-Authored-By: Magomed Khamidov <mago.khamidov@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
|
Visual Regression Test Results ✅ PassedChromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=747 👉 Please review the visual changes in Chromatic and accept or reject them. |
📦 Bundle Size Check✅ All bundles are within size limits 📊 View detailed bundle sizes> @reown/appkit-monorepo@1.7.1 size /home/runner/work/appkit/appkit > size-limit |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Description
When a payment is made through an exchange (e.g., Binance), the "Processing payment..." screen previously always displayed "Wallet" as the label, even when the connected entity is an exchange. This PR conditionally renders "Exchange" when
selectedExchangeis set, and "Wallet" otherwise.Change: In
w3m-pay-loading-view, the hardcoded"Wallet"text inrenderWallet()is replaced with${this.selectedExchange ? 'Exchange' : 'Wallet'}.The existing test for exchange display is extended to assert that the "Exchange" label appears and "Wallet" does not.
Type of change
Human Review Checklist
w3m-pay-quote-view) where a similar "Wallet" → "Exchange" label change is also neededAssociated Issues
N/A
Checklist
Link to Devin run: https://app.devin.ai/sessions/11056cf8bd344e0780b9650ee4a54e5f
Requested by: @magiziz