Skip to content

fix: show "Exchange" label instead of "Wallet" when exchange is selected in pay loading view - #5543

Merged
0xmkh merged 1 commit into
mainfrom
devin/1771233572-pay-exchange-label
Feb 16, 2026
Merged

fix: show "Exchange" label instead of "Wallet" when exchange is selected in pay loading view#5543
0xmkh merged 1 commit into
mainfrom
devin/1771233572-pay-exchange-label

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Description

When a payment is made through an exchange (e.g., Binance), the "Processing payment..." screen previously always displayed "Wallet" as the label, even when the connected entity is an exchange. This PR conditionally renders "Exchange" when selectedExchange is set, and "Wallet" otherwise.

Change: In w3m-pay-loading-view, the hardcoded "Wallet" text in renderWallet() is replaced with ${this.selectedExchange ? 'Exchange' : 'Wallet'}.

The existing test for exchange display is extended to assert that the "Exchange" label appears and "Wallet" does not.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Human Review Checklist

  • Verify there are no other views (e.g., w3m-pay-quote-view) where a similar "Wallet" → "Exchange" label change is also needed
  • Visually confirm the label renders correctly for both exchange and non-exchange payment flows on the preview link

Associated Issues

N/A

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Link to Devin run: https://app.devin.ai/sessions/11056cf8bd344e0780b9650ee4a54e5f
Requested by: @magiziz

…in pay loading view

Co-Authored-By: Magomed Khamidov <mago.khamidov@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@vercel

vercel Bot commented Feb 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
appkit-basic-html Ready Ready Preview, Comment Feb 16, 2026 9:26am
appkit-demo Ready Ready Preview, Comment Feb 16, 2026 9:26am
appkit-gallery Ready Ready Preview, Comment Feb 16, 2026 9:26am
appkit-headless-sample-app Ready Ready Preview, Comment Feb 16, 2026 9:26am
appkit-laboratory Ready Ready Preview, Comment Feb 16, 2026 9:26am
10 Skipped Deployments
Project Deployment Actions Updated (UTC)
appkit-basic-example Ignored Ignored Feb 16, 2026 9:26am
appkit-basic-sign-client-example Ignored Ignored Feb 16, 2026 9:26am
appkit-basic-up-example Ignored Ignored Feb 16, 2026 9:26am
appkit-ethers5-bera Ignored Ignored Feb 16, 2026 9:26am
appkit-nansen-demo Ignored Ignored Feb 16, 2026 9:26am
appkit-vue-solana Ignored Ignored Feb 16, 2026 9:26am
appkit-wagmi-cdn-example Ignored Ignored Feb 16, 2026 9:26am
ethereum-provider-wagmi-example Ignored Ignored Feb 16, 2026 9:26am
next-wagmi-solana-bitcoin-example Ignored Ignored Feb 16, 2026 9:26am
vue-wagmi-example Ignored Ignored Feb 16, 2026 9:26am

Request Review

@changeset-bot

changeset-bot Bot commented Feb 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1e96c71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Visual Regression Test Results ✅ Passed

⚠️ 15 visual change(s) detected

Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=747
Storybook Preview: https://6493191bf4b10fed8ca7353f-xzvycohirz.chromatic.com/

👉 Please review the visual changes in Chromatic and accept or reject them.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Bundle Size Check

All bundles are within size limits

📊 View detailed bundle sizes

> @reown/appkit-monorepo@1.7.1 size /home/runner/work/appkit/appkit


> size-limit

@reown/appkit - Main Entry
Size limit:   80 kB
Size:         75.4 kB with all dependencies, minified and gzipped
Loading time: 1.5 s   on slow 3G
Running time: 217 ms  on Snapdragon 410
Total time:   1.7 s
@reown/appkit/react
Size limit:   235 kB
Size:         233.51 kB with all dependencies, minified and gzipped
Loading time: 4.6 s     on slow 3G
Running time: 489 ms    on Snapdragon 410
Total time:   5.1 s
@reown/appkit/vue
Size limit:   80 kB
Size:         75.4 kB with all dependencies, minified and gzipped
Loading time: 1.5 s   on slow 3G
Running time: 235 ms  on Snapdragon 410
Total time:   1.8 s
@reown/appkit-scaffold-ui
Size limit:   220 kB
Size:         213.41 kB with all dependencies, minified and gzipped
Loading time: 4.2 s     on slow 3G
Running time: 357 ms    on Snapdragon 410
Total time:   4.6 s
@reown/appkit-ui
Size limit:   500 kB
Size:         13.16 kB with all dependencies, minified and gzipped
Loading time: 258 ms   on slow 3G
Running time: 85 ms    on Snapdragon 410
Total time:   342 ms

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.66% 39488 / 50199
🔵 Statements 78.66% 39488 / 50199
🔵 Functions 76.34% 4250 / 5567
🔵 Branches 86.73% 9615 / 11085
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/pay/src/ui/w3m-pay-loading-view/index.ts 87.45% 91.91% 100% 87.45% 400, 430-431, 433-434, 458-462, 467-471, 476-480, 99-384
Generated in workflow #16850 for commit 1e96c71 by the Vitest Coverage Report Action

@0xmkh
0xmkh merged commit b2fbc8b into main Feb 16, 2026
82 of 84 checks passed
@0xmkh
0xmkh deleted the devin/1771233572-pay-exchange-label branch February 16, 2026 12:59
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant