Skip to content

fix: add Tron chain icon to namespace icons in wallet list - #5572

Merged
0xmkh merged 1 commit into
mainfrom
devin/REOWN-4527-1772543134
Mar 3, 2026
Merged

fix: add Tron chain icon to namespace icons in wallet list#5572
0xmkh merged 1 commit into
mainfrom
devin/REOWN-4527-1772543134

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Description

Adds the missing Tron (TRX) chain icon that was not displaying in the multichain/multiwallet wallet list UI. Previously, the NAMESPACE_ICONS map in wui-list-wallet had tron mapped to undefined, causing no icon to render for the Tron namespace.

Changes:

  • Created packages/ui/src/assets/svg/tron.ts with the official TRON logo SVG
  • Added 'tron' to the IconType union type
  • Registered the Tron SVG in the wui-icon component (import, phosphorIconsMap, svgOptions)
  • Mapped tron'tron' in the NAMESPACE_ICONS constant

Reviewer note: The Tron SVG uses a viewBox="0 0 64 64" which is larger than other chain icons (e.g., 0 0 10 10 for TON, 0 0 10 8 for Solana). SVG scaling should handle this correctly, but please verify the icon renders properly at the small namespace icon size in the wallet list. Visual testing on a preview deployment is recommended.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

Closes REOWN-4527

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Link to Devin session: https://app.devin.ai/sessions/66c7934dad494a9ea9fdf841409c4c8b
Requested by: @magiziz

Co-Authored-By: Magomed Khamidov <mago.khamidov@gmail.com>
@linear

linear Bot commented Mar 3, 2026

Copy link
Copy Markdown

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@vercel

vercel Bot commented Mar 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
appkit-demo Building Building Preview, Comment Mar 3, 2026 1:10pm
appkit-gallery Building Building Preview, Comment Mar 3, 2026 1:10pm
appkit-headless-sample-app Building Building Preview, Comment Mar 3, 2026 1:10pm
appkit-laboratory Building Building Preview, Comment Mar 3, 2026 1:10pm
9 Skipped Deployments
Project Deployment Actions Updated (UTC)
appkit-basic-example Ignored Ignored Mar 3, 2026 1:10pm
appkit-basic-sign-client-example Ignored Ignored Mar 3, 2026 1:10pm
appkit-basic-up-example Ignored Ignored Mar 3, 2026 1:10pm
appkit-ethers5-bera Ignored Ignored Mar 3, 2026 1:10pm
appkit-nansen-demo Ignored Ignored Mar 3, 2026 1:10pm
appkit-wagmi-cdn-example Ignored Ignored Mar 3, 2026 1:10pm
ethereum-provider-wagmi-example Ignored Ignored Mar 3, 2026 1:10pm
next-wagmi-solana-bitcoin-example Ignored Ignored Mar 3, 2026 1:10pm
vue-wagmi-example Ignored Ignored Mar 3, 2026 1:10pm

Request Review

@changeset-bot

changeset-bot Bot commented Mar 3, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4f69889

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Visual Regression Test Results ✅ Passed

⚠️ 15 visual change(s) detected

Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=801
Storybook Preview: https://6493191bf4b10fed8ca7353f-qismcaryph.chromatic.com/

👉 Please review the visual changes in Chromatic and accept or reject them.

@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️

🌐 Non-company domain introduced (host: www.w3.org) in packages/ui/src/assets/svg/tron.ts (line 4): http://www.w3.org/2000/svg

⚠️

🌐 Non-company domain introduced (host: www.w3.org) in packages/ui/src/assets/svg/tron.ts (line 4): http://www.w3.org/2000/svg

Generated by 🚫 dangerJS against 4f69889

@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size Check

All bundles are within size limits

📊 View detailed bundle sizes

> @reown/appkit-monorepo@1.7.1 size /home/runner/work/appkit/appkit


> size-limit

@reown/appkit - Main Entry
Size limit:   80 kB
Size:         75.64 kB with all dependencies, minified and gzipped
Loading time: 1.5 s    on slow 3G
Running time: 452 ms   on Snapdragon 410
Total time:   2 s
@reown/appkit/react
Size limit:   235 kB
Size:         234.71 kB with all dependencies, minified and gzipped
Loading time: 4.6 s     on slow 3G
Running time: 1.2 s     on Snapdragon 410
Total time:   5.8 s
@reown/appkit/vue
Size limit:   80 kB
Size:         75.64 kB with all dependencies, minified and gzipped
Loading time: 1.5 s    on slow 3G
Running time: 317 ms   on Snapdragon 410
Total time:   1.8 s
@reown/appkit-scaffold-ui
Size limit:   220 kB
Size:         213.99 kB with all dependencies, minified and gzipped
Loading time: 4.2 s     on slow 3G
Running time: 536 ms    on Snapdragon 410
Total time:   4.8 s
@reown/appkit-ui
Size limit:   500 kB
Size:         13.16 kB with all dependencies, minified and gzipped
Loading time: 258 ms   on slow 3G
Running time: 171 ms   on Snapdragon 410
Total time:   428 ms

@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.63% 39615 / 50377
🔵 Statements 78.63% 39615 / 50377
🔵 Functions 76.34% 4251 / 5568
🔵 Branches 86.7% 9629 / 11106
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/ui/src/assets/svg/tron.ts 100% 100% 100% 100%
packages/ui/src/components/wui-icon/index.ts 100% 100% 77.14% 100%
packages/ui/src/composites/wui-list-wallet/index.ts 72.28% 40% 100% 72.28% 85-102, 109, 114-115, 119-123, 125-126, 133, 138-139
packages/ui/src/utils/TypeUtil.ts 100% 100% 100% 100%
Generated in workflow #16952 for commit 4f69889 by the Vitest Coverage Report Action

@0xmkh
0xmkh merged commit 5f48b54 into main Mar 3, 2026
93 of 102 checks passed
@0xmkh
0xmkh deleted the devin/REOWN-4527-1772543134 branch March 3, 2026 14:11
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant