fix(siwx): preserve signing context in multichain wallet sessions - #5736
Merged
Conversation
🦋 Changeset detectedLatest commit: ef376ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
9 Skipped Deployments
|
Contributor
Visual Regression Test Results ✅ PassedChromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=1030 👉 Please review the visual changes in Chromatic and accept or reject them. |
Contributor
📦 Bundle Size Check✅ All bundles are within size limits 📊 View detailed bundle sizes> @reown/appkit-monorepo@1.7.1 size /home/runner/work/appkit/appkit > size-limit |
Contributor
0xmkh
force-pushed
the
fix/siwx-signing-context-clean
branch
from
August 1, 2026 17:59
6b332d1 to
6de1ca6
Compare
0xmkh
force-pushed
the
fix/siwx-signing-context-clean
branch
from
August 1, 2026 21:55
ff5a607 to
99da4f4
Compare
Pass caipNetworkId explicitly to UniversalProvider.request() for WalletConnect connections to ensure correct chain context is used, fixing SIWX signing failures with multichain wallets (Trust, SafePal).
0xmkh
force-pushed
the
fix/siwx-signing-context-clean
branch
from
August 1, 2026 21:58
1830cb8 to
2834963
Compare
Contributor
|
Approved, do we need to fix this on ethers level as well? |
svenvoskamp
approved these changes
Aug 5, 2026
Collaborator
Author
Nope since we don't set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
namespacechanges between message creation and signingDefaultSignernow calls adapter directly using captured chainId