Fix image for broken image urls in token list - #5747
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
🦋 Changeset detectedLatest commit: c03912d The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
9 Skipped Deployments
|
Visual Regression Test Results ✅ PassedChromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=1037 👉 Please review the visual changes in Chromatic and accept or reject them. |
📦 Bundle Size Check✅ All bundles are within size limits 📊 View detailed bundle sizes> @reown/appkit-monorepo@1.7.1 size /home/runner/work/appkit/appkit > size-limit |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Description
Tokens with a dead or unreachable
iconUrlwere rendering the browser's native broken image icon instead of falling back to the placeholder icon. This only affected the "URL present but fails to load" case; a missing/emptyiconUrlalready fell back correctly.wui-list-tokenrenders a rawwui-imagewhenevertokenImageUrlis set, but never reacted to the image actually failing to load. Other composites in the same package (wui-token-list-item,wui-transaction-visual) already listen forwui-image'sonLoadErrorevent and swap to a placeholder icon;wui-list-tokenwas the one place missing that handling.Added an
imageErrorstate towui-list-tokenthat gets set ononLoadErrorand falls back to the existingcoinPlaceholdericon, matching the pattern already used elsewhere. The state resets whenevertokenImageUrlchanges so a recycled list item does not get stuck showing the placeholder for a different token whose icon loads fine.Type of change
Associated Issues
Closes REOWN-4538
Showcase (Optional)
Checklist