Skip to content

feat: exchange projectid validation #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 19, 2025

Conversation

lukaisailovic
Copy link
Contributor

Description

Added an allowlist for pay with exchange feature. Current implementation is based on what we already have in the code (balance denylist) and naively checks the projectId.

If we see the need, we can also implement the check for allowed origins in the future.

Resolves PAY-29

How Has This Been Tested?

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@lukaisailovic lukaisailovic self-assigned this May 16, 2025
Copy link

linear bot commented May 16, 2025

@lukaisailovic lukaisailovic force-pushed the feat/exchange-projectid-validation branch from 77b57c9 to e63cbc9 Compare May 18, 2025 23:55
@lukaisailovic lukaisailovic merged commit b106c91 into master May 19, 2025
20 checks passed
@lukaisailovic lukaisailovic deleted the feat/exchange-projectid-validation branch May 19, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants