Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/release-appkit.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Stub workflow to enable dispatch from feature branches
# Real implementation is on chore/ci-improvements branch
name: Release AppKit

on:
workflow_dispatch:
inputs:
platform:
description: 'Platform to build'
required: true
type: choice
options:
- android
- ios
release-type:
description: 'Release type'
required: true
type: choice
options:
- internal
- production
e2e-build:
description: 'Build for E2E tests (uploads to S3 for AppKit SDK repo tests)'
required: false
type: boolean
default: false

jobs:
stub:
runs-on: ubuntu-latest
steps:
- run: echo "This is a stub. Run from feature branch with --ref"
Comment on lines +30 to +32

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI about 11 hours ago

In general, the fix is to explicitly define a permissions block for the workflow (or specific jobs) that grants only the minimal required scopes to GITHUB_TOKEN. For a stub job that only runs a shell echo command and does not interact with the GitHub API or repository contents, the safest and most accurate configuration is to fully disable GITHUB_TOKEN by setting permissions: {} at the workflow level.

Concretely, in .github/workflows/release-appkit.yaml, add a permissions: {} block near the top of the workflow (after the name: line and before on:) so that it applies to all jobs. This ensures that the stub job has no token permissions at all, matching its current behavior and not changing any existing functionality. No imports or additional definitions are needed because this is a YAML configuration change only.

Suggested changeset 1
.github/workflows/release-appkit.yaml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/release-appkit.yaml b/.github/workflows/release-appkit.yaml
--- a/.github/workflows/release-appkit.yaml
+++ b/.github/workflows/release-appkit.yaml
@@ -2,6 +2,8 @@
 # Real implementation is on chore/ci-improvements branch
 name: Release AppKit
 
+permissions: {}
+
 on:
   workflow_dispatch:
     inputs:
EOF
@@ -2,6 +2,8 @@
# Real implementation is on chore/ci-improvements branch
name: Release AppKit

permissions: {}

on:
workflow_dispatch:
inputs:
Copilot is powered by AI and may make mistakes. Always verify output.
27 changes: 27 additions & 0 deletions .github/workflows/release-pos.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Stub workflow to enable dispatch from feature branches
# Real implementation is on chore/ci-improvements branch
name: Release Mobile POS

on:
workflow_dispatch:
inputs:
platform:
description: 'Platform to build'
required: true
type: choice
options:
- android
- ios
variant:
description: 'App variant'
required: true
type: choice
options:
- production
- legacy

jobs:
stub:
runs-on: ubuntu-latest
steps:
- run: echo "This is a stub. Run from feature branch with --ref"
Comment on lines +25 to +27

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI about 11 hours ago

In general, the fix is to explicitly define a permissions block for the workflow or for the specific job, setting the GITHUB_TOKEN to the minimal required permissions. Since this stub job does not interact with GitHub APIs at all, we can safely set permissions: contents: read at the workflow level, which is the typical minimal baseline and satisfies the CodeQL recommendation while preserving behavior.

The best way to fix this without changing functionality is to add a workflow-level permissions section just after the name field (around line 4), before the on: block. This ensures all jobs in this workflow default to these restricted permissions. Concretely, in .github/workflows/release-pos.yaml, insert:

permissions:
  contents: read

between the existing name: Release Mobile POS line and the on: block. No additional imports, methods, or other definitions are needed, as this is purely a YAML configuration change to the GitHub Actions workflow.

Suggested changeset 1
.github/workflows/release-pos.yaml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/release-pos.yaml b/.github/workflows/release-pos.yaml
--- a/.github/workflows/release-pos.yaml
+++ b/.github/workflows/release-pos.yaml
@@ -1,6 +1,8 @@
 # Stub workflow to enable dispatch from feature branches
 # Real implementation is on chore/ci-improvements branch
 name: Release Mobile POS
+permissions:
+  contents: read
 
 on:
   workflow_dispatch:
EOF
@@ -1,6 +1,8 @@
# Stub workflow to enable dispatch from feature branches
# Real implementation is on chore/ci-improvements branch
name: Release Mobile POS
permissions:
contents: read

on:
workflow_dispatch:
Copilot is powered by AI and may make mistakes. Always verify output.
32 changes: 32 additions & 0 deletions .github/workflows/release-walletkit.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Stub workflow to enable dispatch from feature branches
# Real implementation is on chore/ci-improvements branch
name: Release WalletKit

on:
workflow_dispatch:
inputs:
platform:
description: 'Platform to build'
required: true
type: choice
options:
- android
- ios
release-type:
description: 'Release type'
required: true
type: choice
options:
- internal
- production
e2e-build:
description: 'Build for E2E tests (uploads to S3 for AppKit SDK repo tests)'
Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description for the 'e2e-build' parameter mentions "AppKit SDK repo tests" in the WalletKit workflow. This should reference WalletKit instead of AppKit for consistency, since this is the WalletKit release workflow.

Suggested change
description: 'Build for E2E tests (uploads to S3 for AppKit SDK repo tests)'
description: 'Build for E2E tests (uploads to S3 for WalletKit SDK repo tests)'

Copilot uses AI. Check for mistakes.
required: false
type: boolean
default: false

jobs:
stub:
runs-on: ubuntu-latest
steps:
- run: echo "This is a stub. Run from feature branch with --ref"
Comment on lines +30 to +32

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI about 11 hours ago

In general, the fix is to explicitly specify permissions for the workflow or each job so that the GITHUB_TOKEN is restricted to the minimum needed (or fully disabled) rather than inheriting potentially broad repository defaults.

For this specific stub workflow, the job only prints a message and does not interact with the GitHub API, so the safest and least-privileged configuration is to set permissions: {} at the workflow (top) level. This disables all default permissions for GITHUB_TOKEN for all jobs in this workflow. Concretely, in .github/workflows/release-walletkit.yaml, add a permissions: {} block near the top-level metadata (e.g., after the name: line and before the on: block). No other functionality changes are required and no additional imports or methods are needed, since this is pure YAML configuration.

Suggested changeset 1
.github/workflows/release-walletkit.yaml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/release-walletkit.yaml b/.github/workflows/release-walletkit.yaml
--- a/.github/workflows/release-walletkit.yaml
+++ b/.github/workflows/release-walletkit.yaml
@@ -1,6 +1,7 @@
 # Stub workflow to enable dispatch from feature branches
 # Real implementation is on chore/ci-improvements branch
 name: Release WalletKit
+permissions: {}
 
 on:
   workflow_dispatch:
EOF
@@ -1,6 +1,7 @@
# Stub workflow to enable dispatch from feature branches
# Real implementation is on chore/ci-improvements branch
name: Release WalletKit
permissions: {}

on:
workflow_dispatch:
Copilot is powered by AI and may make mistakes. Always verify output.