fix: type code for networks #382
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit-710
reviewed
Apr 29, 2025
| + import { createAppKit } from '@reown/appkit'; | ||
| + export const networks = [mainnet, arbitrum] | ||
| + export const networks = [mainnet, arbitrum] as [AppKitNetwork, ...AppKitNetwork[]] |
There was a problem hiding this comment.
Do we really need this?
All my demos work without exporting it with this type format
There was a problem hiding this comment.
Did you try to build them ?
There was a problem hiding this comment.
Yes, the demos are live and deployed via Vercel. My Vercel build always goes through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix code type for networks
Tests