-
Notifications
You must be signed in to change notification settings - Fork 77
added info about handling web wallet #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
added info about handling web wallet #388
Conversation
We recommend closing the web wallet tab after the user approves the request and redirecting back to the dApp. For web requests, redirect to the original browser tab, and for mobile requests, redirect to the native mobile dApp. | ||
|
||
<Info> | ||
To test your web wallet connection flow, use our [Appkit Laboratory](https://appkit-lab.reown.com/) by adding a custom wallet with your web wallet URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vrajdesai78 can we add the steps that one needs to take to add a custom wallet to AppKit lab? I know it is very straight forward but this isn't always obvious to lot of our customers.
2. Implement a scanner to read the WC URI from a WalletConnect QR code | ||
3. Allow users to manually enter the WC URI in an input field | ||
|
||
When opening the wallet directly from the dApp, the `WC_URI` will be in the following format in the query parameters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to add a similar paragraph about session requests. The UR for session requests is {YOUR_WALLET_URL}/wc?requestId={requestId}&sessionTopic={session.Topic}
{YOUR_WALLET_URL}/wc?uri={WC_URI} | ||
``` | ||
|
||
We recommend closing the web wallet tab after the user approves the request and redirecting back to the dApp. For web requests, redirect to the original browser tab, and for mobile requests, redirect to the native mobile dApp. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explain how to redirect to the native app? The link to the native app may be available inside of peer metadata, otherwise, they should probably show "go back to the app" message.
Description
Enter the description of this PR and add any important context/info.
Tests