Skip to content

Add CLAUDE.md for Claude Code guidance#245

Closed
jakubuid wants to merge 1 commit intodevelopfrom
docs/add-claude-md
Closed

Add CLAUDE.md for Claude Code guidance#245
jakubuid wants to merge 1 commit intodevelopfrom
docs/add-claude-md

Conversation

@jakubuid
Copy link
Collaborator

@jakubuid jakubuid commented Jan 6, 2026

Summary

  • Add CLAUDE.md documentation file to help Claude Code instances work effectively with this codebase
  • Includes build commands, architecture overview, testing instructions, and key conventions
  • Provides high-level understanding of the four-layer SDK architecture

Test plan

  • Verify CLAUDE.md file is properly formatted
  • Confirm all build commands are accurate
  • Review architecture description matches current codebase structure

🤖 Generated with Claude Code

Add documentation file to help Claude Code instances work effectively
with this codebase. Includes build commands, architecture overview,
testing instructions, and key conventions.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@claude
Copy link

claude bot commented Jan 6, 2026

Claude finished @jakubuid's task in 1m 58s —— View job


Review Complete

  • Read CLAUDE.md file
  • Verify project structure matches documented architecture
  • Check SDK versions and technical specifications
  • Verify sample apps and test commands
  • Report findings

Issue 1: Target SDK version mismatch between documentation and actual codebase

ID: claude-targetsdkver-a8f2
File: CLAUDE.md:114
Severity: MEDIUM
Category: documentation_accuracy

CLAUDE.md states "Target SDK: 35" but gradle/libs.versions.toml:12 defines targetSdk = "34". The actual target SDK configured in the project is 34, not 35.

Recommendation: Update CLAUDE.md line 114 to match actual configuration:

- Target SDK: 34

Issue 2: product/pay/ module referenced but does not exist in codebase

ID: claude-pay-module-b7c3
File: CLAUDE.md:49
Severity: HIGH
Category: documentation_accuracy

CLAUDE.md architecture diagram lists "product/pay/ - Payment integration" in the PRODUCT LAYER, but this directory does not exist in the repository. Only product/walletkit/, product/appkit/, and product/pos/ exist.

Recommendation: Remove the non-existent pay module from the architecture diagram:

│  PRODUCT LAYER                                          │
│  product/walletkit/  - High-level wallet SDK            │
│  product/appkit/     - High-level dApp SDK (Compose UI) │
│  product/pos/        - Point of Sale                    │

Automated Checks

✅ No external domain URLs detected
✅ No cache-control issues detected
✅ No workflow security issues detected


@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2026

## Important Conventions

- Min SDK: 23 (POS module requires 29)
- Target SDK: 35
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Auto Review Issue: Target SDK version mismatch between documentation and actual codebase

Severity: MEDIUM
Category: documentation_accuracy
Tool: Claude Auto Review

Recommendation: Update CLAUDE.md line 114 to match actual configuration:

- Target SDK: 34

│ PRODUCT LAYER │
│ product/walletkit/ - High-level wallet SDK │
│ product/appkit/ - High-level dApp SDK (Compose UI) │
│ product/pay/ - Payment integration │
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Auto Review Issue: product/pay/ module referenced but does not exist in codebase

Severity: HIGH
Category: documentation_accuracy
Tool: Claude Auto Review

Recommendation: Remove the non-existent pay module from the architecture diagram:

│  PRODUCT LAYER                                          │
│  product/walletkit/  - High-level wallet SDK            │
│  product/appkit/     - High-level dApp SDK (Compose UI) │
│  product/pos/        - Point of Sale                    │

@jakubuid jakubuid closed this Jan 6, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2026
@jakubuid jakubuid deleted the docs/add-claude-md branch January 6, 2026 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant