Skip to content

Comments

chore: bump yttrium to 0.10.43#303

Merged
jakubuid merged 4 commits intodevelopfrom
chore/bump-yttrium-0.10.43
Feb 19, 2026
Merged

chore: bump yttrium to 0.10.43#303
jakubuid merged 4 commits intodevelopfrom
chore/bump-yttrium-0.10.43

Conversation

@jakubuid
Copy link
Collaborator

Summary

  • Bump yttrium-utils from 0.10.29 to 0.10.43 in sample/wallet
  • Bump yttrium-wcpay from 0.10.41 to 0.10.43 in product/pay

Release: https://github.com/reown-com/yttrium/releases/tag/kotlin-0.10.43

Test plan

  • Build sample wallet app
  • Build pay module
  • Verify payment flow works end-to-end

🤖 Generated with Claude Code

jakubuid and others added 3 commits February 18, 2026 13:51
- yttrium-utils: 0.10.29 → 0.10.43 (sample/wallet)
- yttrium-wcpay: 0.10.41 → 0.10.43 (product/pay)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@claude
Copy link

claude bot commented Feb 19, 2026

Claude finished @jakubuid's task in 32s —— View job


✅ No issues found

Simple dependency version bump aligning both yttrium packages to 0.10.43:

  • yttrium-wcpay: 0.10.41 → 0.10.43 (product/pay/build.gradle.kts:82)
  • yttrium-utils: 0.10.29 → 0.10.43 (sample/wallet/build.gradle.kts:93)

Both packages are now on the same version, consistent with the upstream kotlin-0.10.43 release.

@claude
Copy link

claude bot commented Feb 19, 2026

Claude finished @jakubuid's task in 1m 7s —— View job


🔄 Incremental Review:

  • Analyze new changes since last review
  • Review Mappers.kt addition

Previous review had no issues. This push adds one line to Mappers.kt to handle the new PollingTimeout error from yttrium 0.10.43.

Found 1 issue(s)

Issue 1: PollingTimeout semantically misclassified as Http error

ID: mappers-polling-timeout-semantic-f9c1
File: product/pay/src/main/java/com/walletconnect/pay/Mappers.kt:239
Severity: MEDIUM
Category: code_quality

Context:

  • Pattern: YttriumConfirmPaymentError.PollingTimeout is mapped to Pay.ConfirmPaymentError.Http(error.v1) — the same type used for actual HTTP failures
  • Risk: Callers cannot distinguish a polling timeout (payment confirmation still pending) from a network/HTTP error, leading to incorrect error handling (e.g., showing "network error" instead of "payment still processing")
  • Impact: PayError has a dedicated Timeout subtype for the same concept; ConfirmPaymentError is inconsistent
  • Trigger: Any confirmPayment call where the yttrium backend exhausts its polling retries

Recommendation: Add a PollingTimeout (or Timeout) subtype to Pay.ConfirmPaymentError in Pay.kt, then update the mapper:

// Pay.kt
sealed class ConfirmPaymentError : Exception() {
    // existing types...
    data class PollingTimeout(override val message: String) : ConfirmPaymentError()
}

// Mappers.kt
is YttriumConfirmPaymentError.PollingTimeout -> Pay.ConfirmPaymentError.PollingTimeout(error.v1)

Fix this →

@sonarqubecloud
Copy link

@jakubuid jakubuid merged commit 29e4be9 into develop Feb 19, 2026
15 checks passed
@jakubuid jakubuid deleted the chore/bump-yttrium-0.10.43 branch February 19, 2026 08:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant