feat(tvf): collect transaction hashes for stellar_signXDR and stellar_signAndSubmitXDR - #346
feat(tvf): collect transaction hashes for stellar_signXDR and stellar_signAndSubmitXDR#346jakubuid wants to merge 1 commit into
Quality Gate failed
Failed conditions
See analysis details on SonarQube Cloud
Annotations
Check warning on line 49 in Sources/WalletConnectRelay/tvf/StellarTVFCollector.swift
sonarqubecloud / SonarCloud Code Analysis
Remove the unused function parameter "rpcMethod" or name it "_".
See more on https://sonarcloud.io/project/issues?id=reown-com_reown-swift&issues=AaAPZFP3Y0oOFI7PbZCU&open=AaAPZFP3Y0oOFI7PbZCU&pullRequest=346
Check warning on line 90 in Tests/RelayerTests/StellarTVFCollectorTests.swift
sonarqubecloud / SonarCloud Code Analysis
Rename function "testParseTxHashes_SignXDR_Testnet" to match the regular expression ^[a-z][a-zA-Z0-9]*$.
See more on https://sonarcloud.io/project/issues?id=reown-com_reown-swift&issues=AaAPZFTaY0oOFI7PbZCZ&open=AaAPZFTaY0oOFI7PbZCZ&pullRequest=346
Check warning on line 133 in Tests/RelayerTests/StellarTVFCollectorTests.swift
sonarqubecloud / SonarCloud Code Analysis
Rename function "testParseTxHashes_ErrorResult_ReturnsNil" to match the regular expression ^[a-z][a-zA-Z0-9]*$.
See more on https://sonarcloud.io/project/issues?id=reown-com_reown-swift&issues=AaAPZFTaY0oOFI7PbZCc&open=AaAPZFTaY0oOFI7PbZCc&pullRequest=346
Check warning on line 22 in Sources/WalletConnectRelay/tvf/StellarTVFCollector.swift
sonarqubecloud / SonarCloud Code Analysis
Rename this constant "STELLAR_SIGN_AND_SUBMIT_XDR" to match the regular expression ^[a-z][a-zA-Z0-9]*$.
See more on https://sonarcloud.io/project/issues?id=reown-com_reown-swift&issues=AaAPZFP3Y0oOFI7PbZCS&open=AaAPZFP3Y0oOFI7PbZCS&pullRequest=346
Check warning on line 78 in Tests/RelayerTests/StellarTVFCollectorTests.swift
sonarqubecloud / SonarCloud Code Analysis
Rename function "testParseTxHashes_SignXDR_FeeBump_YieldsCanonicalFeeBumpHash" to match the regular expression ^[a-z][a-zA-Z0-9]*$.
See more on https://sonarcloud.io/project/issues?id=reown-com_reown-swift&issues=AaAPZFTaY0oOFI7PbZCY&open=AaAPZFTaY0oOFI7PbZCY&pullRequest=346
Check warning on line 24 in Sources/WalletConnectRelay/tvf/StellarTVFCollector.swift
sonarqubecloud / SonarCloud Code Analysis
"passphrase" detected here, make sure this is not a hard-coded credential.
See more on https://sonarcloud.io/project/issues?id=reown-com_reown-swift&issues=AaAPZFP3Y0oOFI7PbZCT&open=AaAPZFP3Y0oOFI7PbZCT&pullRequest=346
Check warning on line 66 in Tests/RelayerTests/StellarTVFCollectorTests.swift
sonarqubecloud / SonarCloud Code Analysis
Rename function "testParseTxHashes_SignXDR_DefaultsToPubnet" to match the regular expression ^[a-z][a-zA-Z0-9]*$.
See more on https://sonarcloud.io/project/issues?id=reown-com_reown-swift&issues=AaAPZFTaY0oOFI7PbZCX&open=AaAPZFTaY0oOFI7PbZCX&pullRequest=346
Check warning on line 54 in Tests/RelayerTests/StellarTVFCollectorTests.swift
sonarqubecloud / SonarCloud Code Analysis
Rename function "testParseTxHashes_SignXDR_PubnetV1" to match the regular expression ^[a-z][a-zA-Z0-9]*$.
See more on https://sonarcloud.io/project/issues?id=reown-com_reown-swift&issues=AaAPZFTaY0oOFI7PbZCW&open=AaAPZFTaY0oOFI7PbZCW&pullRequest=346
Check warning on line 49 in Sources/WalletConnectRelay/tvf/StellarTVFCollector.swift
sonarqubecloud / SonarCloud Code Analysis
Remove the unused function parameter "rpcParams" or name it "_".
See more on https://sonarcloud.io/project/issues?id=reown-com_reown-swift&issues=AaAPZFP3Y0oOFI7PbZCV&open=AaAPZFP3Y0oOFI7PbZCV&pullRequest=346
Check warning on line 102 in Tests/RelayerTests/StellarTVFCollectorTests.swift
sonarqubecloud / SonarCloud Code Analysis
Rename function "testParseTxHashes_SignAndSubmitXDR_ExtractsTxHash" to match the regular expression ^[a-z][a-zA-Z0-9]*$.
See more on https://sonarcloud.io/project/issues?id=reown-com_reown-swift&issues=AaAPZFTaY0oOFI7PbZCa&open=AaAPZFTaY0oOFI7PbZCa&pullRequest=346
Check warning on line 21 in Sources/WalletConnectRelay/tvf/StellarTVFCollector.swift
sonarqubecloud / SonarCloud Code Analysis
Rename this constant "STELLAR_SIGN_XDR" to match the regular expression ^[a-z][a-zA-Z0-9]*$.
See more on https://sonarcloud.io/project/issues?id=reown-com_reown-swift&issues=AaAPZFP3Y0oOFI7PbZCR&open=AaAPZFP3Y0oOFI7PbZCR&pullRequest=346
Check warning on line 12 in Sources/WalletConnectRelay/tvf/StellarTVFCollector.swift
sonarqubecloud / SonarCloud Code Analysis
Rename this constant "tx_hash" to match the regular expression ^[a-z][a-zA-Z0-9]*$.
See more on https://sonarcloud.io/project/issues?id=reown-com_reown-swift&issues=AaAPZFP3Y0oOFI7PbZCQ&open=AaAPZFP3Y0oOFI7PbZCQ&pullRequest=346
Check warning on line 121 in Tests/RelayerTests/StellarTVFCollectorTests.swift
sonarqubecloud / SonarCloud Code Analysis
Rename function "testParseTxHashes_MalformedEnvelope_ReturnsNil" to match the regular expression ^[a-z][a-zA-Z0-9]*$.
See more on https://sonarcloud.io/project/issues?id=reown-com_reown-swift&issues=AaAPZFTaY0oOFI7PbZCb&open=AaAPZFTaY0oOFI7PbZCb&pullRequest=346