-
Notifications
You must be signed in to change notification settings - Fork 370
feat: react-dapp-v2 updated for Tezos #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@dianasavvatina is attempting to deploy a commit to the WalletConnect Team on Vercel. A member of the Team first needs to authorize it. |
ea3b504
to
53a2821
Compare
53a2821
to
9b88625
Compare
Updated for Tezos: - fixed RPC calls - fixed modals for better user experience - added examples for contract calls, delegation, and more - added balance and token metadata
9b88625
to
77c9121
Compare
Hey @ganchoradkov, could you help @dianasavvatina with this please ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR! Thank you improving the Tezos implementation example. 💯
I have only one remark regarding tezos methods constants, once fixed we should be good to merge 💯
@@ -48,6 +48,7 @@ import { | |||
DEFAULT_MULTIVERSX_METHODS, | |||
DEFAULT_TRON_METHODS, | |||
DEFAULT_TEZOS_METHODS, | |||
TEZOS_SAMPLE_KINDS, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we bundle TEZOS_SAMPLE_KINDS
and DEFAULT_TEZOS_METHODS
into single prop DEFAULT_TEZOS_METHODS
so we can keep the current app convention and reduce complexity of handling two method sources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ganchoradkov, Tezos has default methods (tezos_getAccounts
, tezos_sign
, tezos_send) which are used when establishing a connection.
the tezos_send method is used nearly for all possible Tezos operations: transaction
, origination
, delegation
, staking, calling smart contracts, etc. So to make an example for Tezos I added a number of sample operations to show how they should look like.
As a result, I have 2 lists of operations:
DEFAULT_TEZOS_METHODS
for 3 allowed methodsTEZOS_SAMPLE_KINDS
a list of methods extended with multiple kinds fortezos_send
. This list is used to show the list of buttons for Tezos operations.
I bundled them now. Hope it looks better now
@ganchoradkov please take a look. I applied comments |
@ganchoradkov please take a look. I applied comments. |
Updated for Tezos: