Added polkadot/api and rewrite sendTransaction #882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
Deploying demo-ai-agents with
|
| Latest commit: |
685c7f8
|
| Status: | 🚫 Build failed. |
There was a problem hiding this comment.
Pull Request Overview
This PR integrates polkadot/api into the project and rewrites the sendTransaction logic to utilize Polkadot blockchain constructs. Key changes include:
- Adding imports and instantiation of the Polkadot API and related modules.
- Rewriting the transaction payload derivation and extrinsic signature logic.
- Updating package.json to include the newest "@polkadot/api" dependency.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| advanced/dapps/react-dapp-v2/src/contexts/JsonRpcContext.tsx | Integrates Polkadot API calls and creates a new extrinsic signature flow for transactions. |
| advanced/dapps/react-dapp-v2/package.json | Adds the "@polkadot/api" dependency required for new blockchain functionalities. |
Comments suppressed due to low confidence (2)
advanced/dapps/react-dapp-v2/src/contexts/JsonRpcContext.tsx:978
- [nitpick] The variable name 'call' is ambiguous; consider renaming it to 'transferCall' to better reflect its purpose.
const call = api.tx.balances.transfer(address, 1000000000000); // 1 DOT
advanced/dapps/react-dapp-v2/src/contexts/JsonRpcContext.tsx:1024
- There is an inconsistency in the representation of 'specVersion' and 'transactionVersion'; while the transactionPayload formats these as hex strings, the addSignature call uses raw numeric values. Consider aligning these formats for consistency.
extrinsic.addSignature(address, `0x${result.signature.replaceAll('0x', '')}`, { ...transactionPayload, specVersion: api.runtimeVersion.specVersion, transactionVersion: api.runtimeVersion.transactionVersion, });
|
@quetool could you check please why it fails to build? |
Maybe it's this? I don't know, I'm not expert here, better you checkout that branch and check cause I didn't introduce this.
I ran ppm build and it didn't fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installed and using "@polkadot/api" to sign and send transaction and verify that we can obtain a transaction hash.
Needs to be ran with some coins either on Polkadot mainnet or westend. I wasn't able to get them on any faucet.