-
Notifications
You must be signed in to change notification settings - Fork 393
refactor: replaces WCM with Appkit #883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
tomiir
reviewed
May 21, 2025
Comment on lines
+147
to
+166
| const mapCaipIdToAppKitCaipNetwork = (caipId: CaipNetworkId): CaipNetwork => { | ||
| const [namespace, chainId] = caipId.split(":"); | ||
| const chain = defineChain({ | ||
| id: chainId, | ||
| caipNetworkId: caipId, | ||
| chainNamespace: namespace as CaipNetwork["chainNamespace"], | ||
| name: "", | ||
| nativeCurrency: { | ||
| name: "", | ||
| symbol: "", | ||
| decimals: 8, | ||
| }, | ||
| rpcUrls: { | ||
| default: { http: ["https://rpc.walletconnect.org/v1"] }, | ||
| }, | ||
| }); | ||
|
|
||
| return chain as CaipNetwork; | ||
| }; | ||
|
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: export this as a util from ak package
tomiir
reviewed
May 21, 2025
Comment on lines
+320
to
+328
| showWallets: true, | ||
| enableEIP6963: false, // Disable 6963 by default | ||
| enableInjected: false, // Disable injected by default | ||
| enableCoinbase: true, // Default to true | ||
| enableWalletConnect: true, // Default to true, | ||
| features: { | ||
| email: false, | ||
| socials: false, | ||
| }, |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of these are defaults
tomiir
approved these changes
May 21, 2025
radumojic
pushed a commit
to radumojic/web-examples
that referenced
this pull request
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
react-appby replacing the deprecatedwcmwithappkit, also I've updated typescript & eslint