Skip to content

feat: Eip155OrSolanaAddressKind #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025
Merged

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Apr 11, 2025

Adds same_kind_as() helper function to help reown-com/blockchain-api#1035

@chris13524 chris13524 self-assigned this Apr 11, 2025
@Copilot Copilot AI review requested due to automatic review settings April 11, 2025 19:01
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

crates/yttrium/src/chain_abstraction/api/prepare.rs:119

  • [nitpick] The match arms in the kind() function rely on conditional compilation. To safeguard against potential configuration issues in the future, consider adding a default catch-all arm (e.g. _ => unreachable!()) to ensure exhaustive matching.
pub fn kind(&self) -> Eip155OrSolanaAddressKind {

@chris13524 chris13524 merged commit 700633e into main May 1, 2025
9 checks passed
@chris13524 chris13524 deleted the feat/eip155-solana-address-kind branch May 1, 2025 14:53
@chris13524 chris13524 restored the feat/eip155-solana-address-kind branch May 22, 2025 18:40
@chris13524 chris13524 deleted the feat/eip155-solana-address-kind branch May 22, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant