Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRO-945, PRO-946, PRO-951] Add tool cache, add CFG rendering + more experiment data #12

Merged
merged 21 commits into from
Jan 18, 2025
Merged

[PRO-945, PRO-946, PRO-951] Add tool cache, add CFG rendering + more experiment data #12

merged 21 commits into from
Jan 18, 2025

Conversation

Domiii
Copy link
Contributor

@Domiii Domiii commented Jan 14, 2025 •
edited
Loading

@Domiii Domiii self-assigned this Jan 14, 2025
@Domiii Domiii changed the title PRO-945 [PRO-945, PRO-946, PRO-951] Fixing CFG + more experiment data Jan 18, 2025
@Domiii Domiii changed the title [PRO-945, PRO-946, PRO-951] Fixing CFG + more experiment data [PRO-945, PRO-946, PRO-951] Add tool cache, add CFG rendering + more experiment data Jan 18, 2025
Domiii
Domiii commented Jan 18, 2025
View reviewed changes
packages/cli/experimentalCommand.ts Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New script for us to run any experimentalCommand.

Domiii
Domiii commented Jan 18, 2025
View reviewed changes
packages/replay-data/src/recordingData/PointQueries.ts
forceLookup,
input: { expression, point: this.point },
cb: async ({ expression }): Promise<ExpressionDependencyResult | undefined> => {
// TODO: Fix the analysis
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix this up after this demo.

@Domiii Domiii mentioned this pull request Jan 18, 2025
Merged
@Domiii Domiii requested a review from bhackett1024 January 18, 2025 19:05
@Domiii Domiii merged commit 0600c67 into main Jan 18, 2025
@Domiii Domiii deleted the dominik/pro-945-bolt-network-data-transfer-bug branch January 18, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhackett1024 bhackett1024 Awaiting requested review from bhackett1024

Assignees

@Domiii Domiii

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Domiii