Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions of npx @replayio/cypress run #202

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

Andarist
Copy link
Member

We are removing the CLI script from the @replayio/cypress package and those changes reflect that.

@Andarist Andarist requested review from bvaughn and filiphric June 12, 2024 14:22
Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
replay-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 3:43pm

Copy link

replay-io bot commented Jun 12, 2024

@bvaughn
Copy link
Contributor

bvaughn commented Jun 12, 2024

Broken links check fails now, which I think means that we still have things that references the deleted test-runners/cypress-io/recording-options page.


{% /tab %}
{% /tabs %}
This is useful for debugging failing tests in pull requests. It records tests and those replays will be available for debugging immediately after tests finish.
Copy link
Contributor

@bvaughn bvaughn Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't figure out how to actually view this content. When I try to open this page by URL or search, I get redirected to reference/ci-workflows/upload-strategies– presumably bc of the vercel.json entry– but that page doesn't have the content here. So is this content even viewable at all?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started to edit this but then figured out that it doesn't even make that much sense (IMHO) to discuss recording strategies. Sure, recording has some overhead but it should be negligible for most users. I don't think people have to be aware of this being configurable anyhow (and it actually isn't in certain scenarios, like with @replayio/playwright).

So then I went to remove references to this and forgot to remove this .md file. I'll remove it in a sec. Please let me know if my reasoning about removing it makes sense to u

@@ -570,7 +570,7 @@
},
{
"source": "/test-suites/_archive/ci-integration/circle-ci",
"destination": "/reference/ci-workflows/recording-strategies"
"destination": "/reference/ci-workflows/upload-strategies"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these redirects blocking the recording-strategies content?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I think describing recording strategies raises the complexity here and we might not actually need this (see here). Since this content did exist, I had to redirect it somewhere and /upload-strategies seemed like a good fit

@bvaughn
Copy link
Contributor

bvaughn commented Jun 12, 2024

FWIW broken links CI check is still failing:

The following links are broken:
/reference/test-runners/cypress-io

@Andarist Andarist merged commit 25c6098 into main Jun 13, 2024
8 checks passed
@Andarist Andarist deleted the remove-recording-strategies branch June 13, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants