Remove mentions of npx @replayio/cypress run
#202
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Broken links check fails now, which I think means that we still have things that references the deleted |
|
|
||
| {% /tab %} | ||
| {% /tabs %} | ||
| This is useful for debugging failing tests in pull requests. It records tests and those replays will be available for debugging immediately after tests finish. |
There was a problem hiding this comment.
I can't figure out how to actually view this content. When I try to open this page by URL or search, I get redirected to reference/ci-workflows/upload-strategies– presumably bc of the vercel.json entry– but that page doesn't have the content here. So is this content even viewable at all?
There was a problem hiding this comment.
I started to edit this but then figured out that it doesn't even make that much sense (IMHO) to discuss recording strategies. Sure, recording has some overhead but it should be negligible for most users. I don't think people have to be aware of this being configurable anyhow (and it actually isn't in certain scenarios, like with @replayio/playwright).
So then I went to remove references to this and forgot to remove this .md file. I'll remove it in a sec. Please let me know if my reasoning about removing it makes sense to u
| @@ -570,7 +570,7 @@ | |||
| }, | |||
| { | |||
| "source": "/test-suites/_archive/ci-integration/circle-ci", | |||
| "destination": "/reference/ci-workflows/recording-strategies" | |||
| "destination": "/reference/ci-workflows/upload-strategies" | |||
There was a problem hiding this comment.
Are these redirects blocking the recording-strategies content?
There was a problem hiding this comment.
Yes. I think describing recording strategies raises the complexity here and we might not actually need this (see here). Since this content did exist, I had to redirect it somewhere and /upload-strategies seemed like a good fit
|
FWIW broken links CI check is still failing: |
We are removing the CLI script from the
@replayio/cypresspackage and those changes reflect that.