Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keyword search capabilities #203

Conversation

filiphric
Copy link
Contributor

This should close DEV-495 and PRO-607.

The way I’m trying to solve search issues is by adding keywords frontmatter attribute that can be fed with keywords. Content should be easier to search in that case. For example if we have "PR Comments" section in navigation, but the title of this page says "Pull request comments", it should be easily found if a keyword such as "PR Comments" is added to the list of keywords.

Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
replay-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 8:22am

Copy link

replay-io bot commented Jun 17, 2024

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just skimmed it but seems okay.

CI failed though because of formatting. (You need to run yarn prettier to fix this.)

@filiphric filiphric force-pushed the filip/dev-495-docs-structure-does-not-play-well-with-search-and-breadcumbs branch from fc8f3d8 to a6e260c Compare June 18, 2024 08:21
@filiphric filiphric merged commit 13d8a86 into main Jun 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants