WIP carb absorption metadata integration to Loop interface - #1
Open
PorkShoulderHolder wants to merge 10 commits into
Open
WIP carb absorption metadata integration to Loop interface#1PorkShoulderHolder wants to merge 10 commits into
PorkShoulderHolder wants to merge 10 commits into
Conversation
Release 3.2
Merge dev into main for 3.2.1 release.
Backport cyclic dependency fixes from dev for building on Xcode 15
| startDate: startDate.addingTimeInterval(.hours(24) * Double(index) / Double(simulatedPerDay)), | ||
| grams: Double(20 + 10 * (index % 3)), | ||
| absorptionTime: .hours(Double(2 + index % 3)), | ||
| absorptionData: nil) |
| foodType: nil, | ||
| absorptionTime: nil) | ||
| absorptionTime: nil, | ||
| absorptionData: nil) |
Author
There was a problem hiding this comment.
should be nil here because this is for missed meal detection (creating from scratch).
|
|
||
| // If the entry is in the past or an entry is replaced, DCA and RC effects must be recomputed | ||
| var entries = recentEntries.map { NewCarbEntry(quantity: $0.quantity, startDate: $0.startDate, foodType: nil, absorptionTime: $0.absorptionTime) } | ||
| var entries = recentEntries.map { NewCarbEntry(quantity: $0.quantity, startDate: $0.startDate, foodType: nil, absorptionTime: $0.absorptionTime, absorptionData: $0.historicalAbsorptionData) } |
Author
There was a problem hiding this comment.
still haven't actually populated historicalAbsorptionData from the metadata string itself anywhere. but after that step and a couple bug fixes this should work...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.