Skip to content

Conversation

@meatballhat
Copy link
Contributor

such that:

  • the container-level ENTRYPOINT is tini
  • the wrapper environment setup file is renamed activate.sh
  • builder-style behavior is explicitly run via build.sh
  • wrapper-style behavior is locally simulated via exec.sh

Connected to PLAT-649

@meatballhat meatballhat requested a review from a team as a code owner December 4, 2024 22:19
such that:
- the container-level `ENTRYPOINT` is `tini`
- the wrapper environment setup file is renamed `activate.sh`
- builder-style behavior is explicitly run via `build.sh`
- wrapper-style behavior is locally simulated via `exec.sh`

Connected to PLAT-649
* Build and install from sdist via uv

mostly so that the generated version metadata is correct.

Connected to PLAT-589

* Don't build and push in pull requests

not least because the git head isn't understandable to setuptools-scm
@meatballhat meatballhat merged commit 39c0ee0 into main Dec 5, 2024
4 checks passed
@meatballhat meatballhat deleted the entryoint-do-si-do branch December 5, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants