Build and install from sdist via uv #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevillelyh
approved these changes
Dec 5, 2024
Contributor
nevillelyh
left a comment
nevillelyh
left a comment
There was a problem hiding this comment.
LGTM except the extra tmp layer
mostly so that the generated version metadata is correct. Connected to PLAT-589
meatballhat
force-pushed
the
docker-build-sdist
branch
from
68e030b to
abb157b
Compare
not least because the git head isn't understandable to setuptools-scm
meatballhat
added a commit
that referenced
this pull request
Dec 5, 2024
* Updating monobase entrypoint and usage such that: - the container-level `ENTRYPOINT` is `tini` - the wrapper environment setup file is renamed `activate.sh` - builder-style behavior is explicitly run via `build.sh` - wrapper-style behavior is locally simulated via `exec.sh` Connected to PLAT-649 * Build and install from sdist via uv (#28) * Build and install from sdist via uv mostly so that the generated version metadata is correct. Connected to PLAT-589 * Don't build and push in pull requests not least because the git head isn't understandable to setuptools-scm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly so that the generated version metadata is correct.
Connected to PLAT-589