build(deps): bump github.com/replicatedhq/troubleshoot from 0.127.1 to 0.130.0#3769
Open
dependabot[bot] wants to merge 6 commits into
Open
Conversation
Bumps [github.com/replicatedhq/troubleshoot](https://github.com/replicatedhq/troubleshoot) from 0.127.1 to 0.130.0. - [Release notes](https://github.com/replicatedhq/troubleshoot/releases) - [Commits](replicatedhq/troubleshoot@v0.127.1...v0.130.0) --- updated-dependencies: - dependency-name: github.com/replicatedhq/troubleshoot dependency-version: 0.130.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/go_modules/github.com/replicatedhq/troubleshoot-0.130.0
branch
from
618b81a to
c011d63
Compare
troubleshoot 0.130.0 pulls in controller-runtime built against
k8s 0.36, which forces the whole module to k8s 0.36. Because
embedded-cluster mirrors k0s's k8s replace block, the k8s bump
requires moving k0s from 1.35 to 1.36 in lockstep.
- go.mod / kinds/go.mod: k8s 0.35.4 -> 0.36.1 (requires + replace
blocks), k0s -> v1.36 (via `make go.mod`, K0S_GO_VERSION).
- versions.mk: add K0S_VERSION_1_36 = v1.36.1+k0s.0, default
K0S_MINOR_VERSION to 36.
- pkg/config/images.go: k0s 1.36 changed airgap.GetImageURIs to take
a TargetEnv{Platform, Spec}. Pin the platform to linux/amd64 (the
base images are only emitted under OS=="linux", and EC always
targets linux nodes). Skip k0s 1.36's new traefik NLLB backend
image — EC uses the envoy NLLB backend, so it is not shipped.
- pkg/config/static/metadata-1_36.yaml: generated via buildtools
(calico v3.32.0, kube-proxy v1.36.2, coredns 3.10.2,
metrics-server 1.14.4).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
troubleshoot 0.130.0 raised the module's go directive to 1.26.4, but the dryrun test container was still pinned to golang:1.26.2-alpine. The container runs with GOTOOLCHAIN=local so it cannot auto-download a newer toolchain, and `go test -c` fails with "go.mod requires go >= 1.26.4 (running go 1.26.2)". Bump the base image to match go.mod. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
EC builds the same source against the current k0s minor plus the three previous minors (the "Build current (0..3)" matrix, for upgrade testing). k0s changed airgap.GetImageURIs incompatibly at 1.36 (it now takes a TargetEnv and adds a traefik NLLB backend image), so a single ListK0sImages implementation cannot compile against both <=1.35 and 1.36+. Split ListK0sImages by a k0s_pre_1_36 build tag: - list_images.go (default): the 1.36+ TargetEnv API path. - list_images_pre_1_36.go: the legacy GetImageURIs(spec, true) path, unchanged from main. - images.go keeps the version-agnostic overrideK0sImages. versions.mk sets the k0s_pre_1_36 tag whenever K0S_MINOR_VERSION < 36, in lockstep with the k0s version selected for go.mod, so each build compiles the implementation matching its k0s API. The default (no tag) matches the committed go.mod at k0s 1.36, so plain `go build`/vet/test and the unit/lint/dryrun jobs use the 1.36 path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The embedded-cluster target built ./cmd/installer with a hardcoded `-tags osusergo,netgo`, omitting $(GO_BUILD_TAGS). cmd/installer imports pkg/config, so on previous-k0s builds (K0S_MINOR_VERSION < 36) it compiled the default k0s 1.36 ListK0sImages against the older k0s API and failed (undefined: airgap.TargetEnv) — the k0s_pre_1_36 tag set in versions.mk never reached this build. Match the operator target's `-tags osusergo,netgo,$(GO_BUILD_TAGS)` so the binary build selects the ListK0sImages implementation matching its go.mod k0s version. The added containers_image_openpgp / exclude_graphdriver_* tags are a no-op here (cmd/installer pulls in neither containers/image signature nor containers/storage graphdrivers). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Same go-floor fix as the dryrun container: troubleshoot 0.130.0 raised
the module's go directive to 1.26.4, but the operator and
local-artifact-mirror dev Dockerfiles (used by the kind integration
tests and ttl.sh image builds) were still on golang:1.26.2 with
GOTOOLCHAIN=local, failing `go mod download` with "go.mod requires go
>= 1.26.4". Bump dev/dockerfiles/{operator,local-artifact-mirror} to
golang:1.26.4.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
Heads up on where this one landed. I took the troubleshoot The interesting part was the build matrix. We compile A couple of other things fell out of the bump:
Everything that validates the code is green across all four k0s minors: Two checks are still red, and I traced both. Neither is from this bump:
So the upgrade itself is done and proven. I'm leaving this open for human review and merge. The two red checks land on the integration-suite and release-bootstrapping side rather than anything in this diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps github.com/replicatedhq/troubleshoot from 0.127.1 to 0.130.0.
Release notes
Sourced from github.com/replicatedhq/troubleshoot's releases.
Commits
22ab3cffeat(redact): make MAX_CONCURRENT_REDACTORS configurable via env var (sc-1383...dcfddc7Bump Go from 1.26.3 to 1.26.4 (#2055)aad5f6echore(deps): bump the security group with 7 updates (#2052)12b0e74feat(ci): add Slack release notification via reusable workflow (#2051)baecd3cchore(deps): bump golang.org/x/net, x/crypto, containerd to patch CVEs (#2049...1cfa00echore(deps): bump the security group with 3 updates (#2048)9600c17chore(deps): bump github.com/containerd/containerd from 1.7.30 to 1.7.32 (#2046)61ef1e1fix: TLS support in MySQL connector (#2045)77e39bcchore(deps): bump helm.sh/helm/v3 from 3.20.2 to 3.21.0 in /examples/sdk/helm...edba8f1chore(deps): bump the security group with 14 updates (#2043)