feat(helm-install): add values-file input and clarify values is inline YAML#109
Merged
jdewinne merged 2 commits intoApr 28, 2026
Merged
Conversation
…e YAML The values input was documented as "A values.yaml file to use" but actually expected inline YAML, leading to confusing helm unmarshal errors when users passed a file path. Add a separate values-file input for paths, validate mutual exclusivity, and fail fast with a clear error if values-file is missing.
The dist bundle is shared across all actions, so a change in any source file requires regenerating every action's dist. Also apply prettier to the new index.test.ts so prettier-check passes in CI.
5 tasks
mikhailswift
approved these changes
Apr 28, 2026
jdewinne
deleted the
joshd/sc-136400/helm-install-action-values-input-expects
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
valuesinput was documented as "A values.yaml file to use" but the action treats it as inline YAML and writes it verbatim to a temp file. Passing a file path produced a confusing helm error:cannot unmarshal string into Go value of type map[string]interface{}.values-fileinput for path-based values, keepsvaluesfor inline YAML, validates mutual exclusivity, and fails fast with a clear error ifvalues-filedoesn't exist.valuesand marks both inputsrequired: falseso the generated README reflects reality.Changes
helm-install/action.yml: newvalues-fileinput; updatedvaluesdescriptionsrc/helm-install/index.ts: readvalues-file, validate mutual exclusivity, error on missing filesrc/helm-install/index.test.ts: new tests covering all brancheshelm-install/dist/and regeneratedhelm-install/README.mdTest plan
Test run: https://github.com/jdewinne/spooky/actions/runs/25031460872
npm test— 22 tests pass (5 new + 17 existing)values: |with inline YAML — works as beforevalues-file: ./ci-values.yaml— values file is read by helmvaluesandvalues-file— action fails fast with mutual-exclusivity errorvalues-fileto a non-existent path — action fails fast with clear "values-file not found" errorCloses sc-136400