[security] update engine.io-client, jest, etc

.gitignore

@@ -14,3 +14,4 @@ yarn-error.log*
 
 .env
 .direnv
+/.eslintcache

eslint.config.js

@@ -0,0 +1,51 @@
+import eslint from "@eslint/js";
+import tseslint from "typescript-eslint";
+import eslintConfigPrettier from "eslint-config-prettier";
+import eslintPluginPrettierRecommended from "eslint-plugin-prettier/recommended";
+
+export default tseslint.config(
+  eslint.configs.recommended,
+  tseslint.configs.recommended,
+  eslintConfigPrettier,
+  eslintPluginPrettierRecommended,
+  {
+    files: ["**/*.js", "**/*.ts"],
+    plugins: {
+      '@typescript-eslint': tseslint.plugin,
+    },
+    languageOptions: {
+      parser: tseslint.parser,
+      parserOptions: {
+        'src': "./tsconfig.json",
+        'src-browser': "./tsconfig.json",
+      },
+      globals: {
+        window: true,
+        browser: true,
+        node: true,
+      },
+    },
+    rules: {
+      'prettier/prettier': 'error',
+      'import/prefer-default-export': 'off',
+      indent: 'off',
+      'implicit-arrow-linebreak': 'off', // conflicts with prettier
+      'no-unused-expressions': 'off', // breaks optional chaining
+      '@typescript-eslint/no-unused-expressions': 'error',
+      'max-len': ['error', { code: 120 }],
+      '@typescript-eslint/no-empty-function': 'off',
+      'no-shadow': 'off',
+      '@typescript-eslint/no-shadow': 'error',
+      '@typescript-eslint/explicit-function-return-type': 'off',
+      '@typescript-eslint/no-non-null-assertion': 'error',
+      'operator-linebreak': 'off',
+      'no-param-reassign': ['error', { props: false }],
+      'object-curly-newline': 'off',
+    },
+    ignores: [
+      "*.d.ts",
+      "api.js",
+      "webpack.config.js",
+    ],
+  }
+);

jest.config.js

@@ -1,4 +1,4 @@
-module.exports = {
+export default {
   preset: 'ts-jest',
   testEnvironment: 'node',
   roots: ['./src'],

package.json

@@ -5,10 +5,11 @@
   "files": [
     "/dist"
   ],
+  "type": "module",
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",
   "scripts": {
-    "lint": "eslint --ext .js,.ts src/ src.browser/",
+    "lint": "eslint --cache src/ src.browser/",
     "build": "tsc",
     "build:browser": "yarn clean && yarn build && parcel build src.browser/index.js -d dist.browser --out-file crosis.js",
     "debug": "node debug/server.js",
@@ -21,29 +22,30 @@
   "author": "[email protected]",
   "license": "MIT",
   "dependencies": {
-    "abortcontroller-polyfill": "1.7.5",
-    "engine.io-client": "3.5.4"
+    "abortcontroller-polyfill": "1.7.8",
+    "engine.io-client": "^6.6.3"
   },
   "devDependencies": {
-    "@replit/protocol": ">=0.3.16",
-    "@types/engine.io-client": "^3.1.8",
-    "@types/jest": "^29.5.12",
-    "@types/node": "^20.14.7",
-    "@types/ws": "^8.5.10",
-    "@typescript-eslint/eslint-plugin": "^7.13.1",
-    "@typescript-eslint/parser": "^7.13.1",
-    "eslint": "^8.15.0",
-    "eslint-config-prettier": "8.5.0",
-    "eslint-plugin-prettier": "4.0.0",
-    "express": "^4.19.2",
+    "@replit/protocol": ">=0.4.8",
+    "@types/engine.io-client": "^6.0.0",
+    "@types/jest": "^29.5.14",
+    "@types/node": "^22.13.4",
+    "@types/ws": "^8.5.14",
+    "@typescript-eslint/eslint-plugin": "^8.24.1",
+    "@typescript-eslint/parser": "^8.24.1",
+    "eslint": "^9.20.1",
+    "eslint-config-prettier": "10.0.1",
+    "eslint-plugin-prettier": "5.2.3",
+    "express": "^4.21.2",
     "jest": "^29.7.0",
     "jest-websocket-mock": "^2.5.0",
     "mock-socket": "^9.3.1",
-    "prettier": "^2.6.2",
-    "ts-jest": "^29.1.5",
-    "typedoc": "^0.25.13",
-    "typescript": "^5.4.5",
-    "ws": "^8.17.1"
+    "prettier": "^3.5.1",
+    "ts-jest": "^29.2.5",
+    "typedoc": "^0.27.7",
+    "typescript": "^5.7.3",
+    "typescript-eslint": "^8.24.1",
+    "ws": "^8.18.0"
   },
   "peerDependencies": {
     "@replit/protocol": ">=0.2.15"

src.browser/index.js

@@ -1,4 +1,3 @@
-// eslint-disable-next-line
 import * as Crosis from '../dist';
 
 window.Crosis = Crosis;

src/__tests__/redirect.test.ts

@@ -8,7 +8,6 @@ import { WebSocket } from 'mock-socket';
 // eslint-disable-next-line
 const genConnectionMetadata = require('../../debug/genConnectionMetadata');
 
-// eslint-disable-next-line
 jest.setTimeout(1000);
 
 const testingClients: Array<Client<{ username: string }>> = [];

src/client.ts

@@ -1881,11 +1881,7 @@ export class Client<Ctx = null> {
       try {
         this.handleClose(ClientCloseReason.ErrorOrDestroy);
       } catch (handleCloseErr) {
-        // We tried our best to clean up. But we need to keep going and report
-        // unrecoverable error regardless of what happens inside handleClose
-        // eslint-disable-next-line no-console
         console.error('handleClose errored during unrecoverable error');
-        // eslint-disable-next-line no-console
         console.error(handleCloseErr);
       }
     }
@@ -1896,7 +1892,6 @@ export class Client<Ctx = null> {
       return;
     }
 
-    // eslint-disable-next-line no-console
     console.error('Please supply your own unrecoverable error handling function');
 
     throw e;

src/util/EIOCompat.ts

@@ -123,7 +123,7 @@ export class EIOCompat implements WebSocket {
     this.onclose = null;
     this.onmessage = null;
     this.onerror = null;
-    this.eioSocket = eio(uri, { path, transports: ['polling'] });
+    this.eioSocket = new eio.Socket(uri, { path, transports: ['polling'] });
     this.url = url;
     this.extensions = '';
     this.protocol = '';
@@ -233,17 +233,14 @@ export class EIOCompat implements WebSocket {
     this.setReadyState();
   }
 
-  // eslint-disable-next-line class-methods-use-this
   addEventListener(): boolean {
     throw new Error('Not Implemented, please use onmessage, onopen, onerror, or onclose');
   }
 
-  // eslint-disable-next-line class-methods-use-this
   removeEventListener(): void {
     throw new Error('Not Implemented');
   }
 
-  // eslint-disable-next-line class-methods-use-this
   dispatchEvent(): boolean {
     throw new Error('Not Implemented');
   }
@@ -253,6 +250,9 @@ export class EIOCompat implements WebSocket {
   }
 
   get binaryType(): BinaryType {
+    if (this.eioSocket.binaryType === 'nodebuffer') {
+      throw new Error('unsupported eioSocket.binaryType nodebuffer');
+    }
     return this.eioSocket.binaryType || 'blob';
   }
 }