Merged
Conversation
❌ Deploy Preview for replugged-docs failed.
|
fedeericodl
added
enhancement
Closed
2 tasks
asportnoy
requested changes
Aug 3, 2023
asportnoy
added
the
addon development
fedeericodl
requested changes
Jul 15, 2025
Member
fedeericodl
left a comment
fedeericodl
left a comment
There was a problem hiding this comment.
byPrototype would be better as its own filter, separate from byProps. Can you implement this change?
fedeericodl
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding an option to getByProps to search only in the prototype, like requested before closing last pr.