Skip to content

feat: use semver #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fedeericodl merged 3 commits into from
Oct 22, 2025
Merged

feat: use semver #756

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72bdbb6
feat: use semver
yofukashino Oct 15, 2025
5ba2ae7
Merge branch 'main' into semver
fedeericodl Oct 22, 2025
475b666
refactor: robustly compare versions
fedeericodl Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/renderer/managers/updater.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { i18n } from "@common";
import semver from "semver";
import type { RepluggedPlugin, RepluggedTheme } from "src/types";
import type { AnyAddonManifest, RepluggedEntity } from "src/types/addon";
import notices from "../apis/notices";
Expand Down Expand Up @@ -64,6 +65,17 @@ const updaterState = init<Record<string, UpdateSettings>>("dev.replugged.Updater

const completedUpdates = new Set<string>();

function isUpToDate(local: string, remote: string): boolean {
if (local === remote) return true;

const localVersion = semver.clean(local) ?? semver.coerce(local)?.version ?? null;
const remoteVersion = semver.clean(remote) ?? semver.coerce(remote)?.version ?? null;

if (!localVersion || !remoteVersion) return false;

return semver.gte(localVersion, remoteVersion);
}

export function getUpdateState(id: string): UpdateSettings | null {
const setting = updaterState.get(id);
if (!setting) return null;
Expand Down Expand Up @@ -136,7 +148,7 @@ export async function checkUpdate(id: string, verbose = true): Promise<void> {

const newVersion = res.manifest.version;

if (newVersion === version) {
if (isUpToDate(version, newVersion)) {
if (verbose) logger.log(`Entity ${id} is up to date`);
updaterState.set(id, {
available: false,
Expand Down