Fix Tip recovery after Stable 1.4.0 - #914
Open
baron wants to merge 2 commits into
Open
Conversation
| "role": "transition", | ||
| "tag": "tip-57b572038048", | ||
| "buildNumber": "35.15.39", | ||
| "rolloutManifestSha256": "c8d28103b5e95370fc0de7df19c34797552e99803228794754bfbfe292e3e421" |
Contributor
There was a problem hiding this comment.
Bug: The rolloutManifestSha256 in tip-rollout.json is an invalid 63-character hash, but the validation code expects a 64-character SHA-256 hash, which will cause a RolloutError.
Severity: CRITICAL
Suggested Fix
Correct the rolloutManifestSha256 value in tip-rollout.json to be a valid 64-character SHA-256 hash. The current hash appears to be missing one character.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: tip-rollout.json#L15
Potential issue: The `rolloutManifestSha256` value in `tip-rollout.json` for the
`liveTip` entry contains a 63-character hash. The `validate_reset_authority_shape`
function validates this using a regex, `r"[0-9a-f]{64}"`, which requires exactly 64
characters. When the Tip publication workflow loads this declaration file, the
validation will fail and raise a `RolloutError`. This deterministic failure will block
the publication process whenever the workflow attempts to load the declaration file
containing the invalid hash.
Also affects:
Scripts/stable_rollout.py:968~974
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resetAuthoritybound to the exact authenticated live transition, retained preparer, and Stable epochRoot cause
Tip builds sort between adjacent Stable integers. Stable 1.4.0 advanced Stable to build 36 while the live transition retained preparer 35.15.18, so the existing floor guard correctly stopped publication. A plain declaration rollback would also be rejected because live Tip is already transition build 35.15.39.
Validation
python3 Scripts/test_release_tooling.pymake release-selftest.agents/skills/rpce-contribution-check/scripts/preflight.sh pr-readymake dev-release-preflight.agents/skills/rpce-contribution-check/scripts/preflight.sh pushgit diff --check origin/main..HEADPR-ready ran the matching conductor self-tests and generated Xcode workspace validation. All checks passed.
Validation boundary
No signing, notarization, Tip publication, workflow dispatch, or other hosted mutation was performed. The protected workflow remains the final integration proof.